Closed Bug 746630 Opened 9 years ago Closed 9 years ago

Make "Setting Up" Screen display not dependent on timing

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 14
Tracking Status
blocking-fennec1.0 --- +

People

(Reporter: gcp, Assigned: gcp)

Details

Attachments

(2 files)

Follow up to bug 721934: we should not display the setting up screen based on a fixed timer, but have the profile migrator call callbacks when it looks like it might take a while.
Assignee: nobody → gpascutto
Attachment #616183 - Flags: review?(blassey.bugs)
Attachment #616184 - Flags: review?(blassey.bugs)
Comment on attachment 616183 [details] [diff] [review]
Patch 1. Use callbacks in Profile Migrator

Review of attachment 616183 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/ProfileMigrator.java
@@ +1224,5 @@
>                  if (db != null) {
>                      db.close();
>                  }
>                  Log.e(LOGTAG, "Error on places database:", e);
>                  return;

Note to self: Remove the return here.
If you have a slow enough phone, this bug can cause you to see the setting up screen every launch. I truly hope there aren't many users like that out there, but at least some people already hit this. Given that it's quite annoying when encountered, nom-ing for beta.
blocking-fennec1.0: --- → ?
Attachment #616183 - Flags: review?(blassey.bugs) → review+
Attachment #616184 - Flags: review?(blassey.bugs) → review+
blocking-fennec1.0: ? → +
https://hg.mozilla.org/mozilla-central/rev/41aa31e62e7b
https://hg.mozilla.org/mozilla-central/rev/47c706c98a82
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
You need to log in before you can comment on or make changes to this bug.