746630 - Make "Setting Up" Screen display not dependent on timing

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

Follow up to bug 721934: we should not display the setting up screen based on a fixed timer, but have the profile migrator call callbacks when it looks like it might take a while.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Use callbacks in Profile Migrator

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 2. Clean up SetupScreen timer support

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 616183 [details] [diff] [review]
Patch 1. Use callbacks in Profile Migrator

Review of attachment 616183 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/ProfileMigrator.java
@@ +1224,5 @@
>                  if (db != null) {
>                      db.close();
>                  }
>                  Log.e(LOGTAG, "Error on places database:", e);
>                  return;

Note to self: Remove the return here.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

If you have a slow enough phone, this bug can cause you to see the setting up screen every launch. I truly hope there aren't many users like that out there, but at least some people already hit this. Given that it's quite annoying when encountered, nom-ing for beta.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41aa31e62e7b
https://hg.mozilla.org/integration/mozilla-inbound/rev/47c706c98a82

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/41aa31e62e7b
https://hg.mozilla.org/mozilla-central/rev/47c706c98a82