Last Comment Bug 746648 - Too large script labels in various pages
: Too large script labels in various pages
Product: Firefox
Classification: Client Software
Component: Developer Tools: Debugger (show other bugs)
: Trunk
: All All
P2 normal (vote)
: Firefox 15
Assigned To: Victor Porof [:vporof][:vp]
: Jason Laster [:jlast]
: 759629 (view as bug list)
Depends on:
  Show dependency treegraph
Reported: 2012-04-18 10:38 PDT by Panos Astithas [:past]
Modified: 2012-05-31 01:58 PDT (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

v1 (4.63 KB, patch)
2012-05-30 03:40 PDT, Victor Porof [:vporof][:vp]
no flags Details | Diff | Splinter Review
v1.1 (4.78 KB, patch)
2012-05-30 03:46 PDT, Victor Porof [:vporof][:vp]
past: review+
Details | Diff | Splinter Review

Description User image Panos Astithas [:past] 2012-04-18 10:38:09 PDT
1) Visit
2) Open the script debugger
3) Observe the huge labels in the script list

In SS__getScriptLabel we trim the query string before deciding on a unique, short label for the script. In this case, however, the query string is what differentiates the script URLs.

The best mitigation I came up with is using the path info as usual, but instead of appending the whole query string, just add a unique subset of it, probably with ellipsis characters before and after.
Comment 1 User image Panos Astithas [:past] 2012-05-30 00:24:21 PDT
*** Bug 759629 has been marked as a duplicate of this bug. ***
Comment 2 User image Panos Astithas [:past] 2012-05-30 00:30:59 PDT from bug 759629 is another good case for huge script labels due to long query strings. In this particular case however, the query string delimiter character '?' is missing, which confuses SS__trimUrlQuery. I'm not even sure such URLs are valid:
Comment 3 User image Victor Porof [:vporof][:vp] 2012-05-30 02:15:15 PDT
(In reply to Panos Astithas [:past] from comment #2)
> I'm not even sure such URLs are valid

Sometimes I'm surprised the whole internet thing even works...
Comment 4 User image Victor Porof [:vporof][:vp] 2012-05-30 03:40:02 PDT
Created attachment 628299 [details] [diff] [review]

Comment 5 User image Victor Porof [:vporof][:vp] 2012-05-30 03:46:59 PDT
Created attachment 628301 [details] [diff] [review]

I just realized that until now, the whole "for (let i = 0; i < vs._scripts.itemCount; i++)" check for script urls was incorrect, because there was no 1:1 relationship between the test urls array and the actual added urls in the dropdown. This means that, although it worked and the order wasn't important, not all the urls were tested. Fixed in this version.
Comment 6 User image Panos Astithas [:past] 2012-05-30 12:23:45 PDT
Comment on attachment 628301 [details] [diff] [review]

Review of attachment 628301 [details] [diff] [review]:

Comment 8 User image Tim Taubert [:ttaubert] 2012-05-31 01:58:27 PDT

Note You need to log in before you can comment on or make changes to this bug.