Closed Bug 746648 Opened 9 years ago Closed 9 years ago

Too large script labels in various pages

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 15

People

(Reporter: past, Assigned: vporof)

References

Details

Attachments

(1 file, 1 obsolete file)

STR:
1) Visit cnn.com
2) Open the script debugger
3) Observe the huge labels in the script list

In SS__getScriptLabel we trim the query string before deciding on a unique, short label for the script. In this case, however, the query string is what differentiates the script URLs.

The best mitigation I came up with is using the path info as usual, but instead of appending the whole query string, just add a unique subset of it, probably with ellipsis characters before and after.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Duplicate of this bug: 759629
(In reply to Panos Astithas [:past] from comment #2)
> I'm not even sure such URLs are valid

Sometimes I'm surprised the whole internet thing even works...
Summary: Too large script labels in cnn.com → Too large script labels in various pages
Attached patch v1 (obsolete) — Splinter Review
Works.
Attachment #628299 - Flags: review?(past)
Attached patch v1.1Splinter Review
I just realized that until now, the whole "for (let i = 0; i < vs._scripts.itemCount; i++)" check for script urls was incorrect, because there was no 1:1 relationship between the test urls array and the actual added urls in the dropdown. This means that, although it worked and the order wasn't important, not all the urls were tested. Fixed in this version.
Attachment #628299 - Attachment is obsolete: true
Attachment #628299 - Flags: review?(past)
Attachment #628301 - Flags: review?(past)
Comment on attachment 628301 [details] [diff] [review]
v1.1

Review of attachment 628301 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #628301 - Flags: review?(past) → review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/fd76266dc5ca
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/fd76266dc5ca
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.