746648 - Too large script labels in various pages

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

STR:
1) Visit cnn.com
2) Open the script debugger
3) Observe the huge labels in the script list

In SS__getScriptLabel we trim the query string before deciding on a unique, short label for the script. In this case, however, the query string is what differentiates the script URLs.

The best mitigation I came up with is using the path info as usual, but instead of appending the whole query string, just add a unique subset of it, probably with ellipsis characters before and after.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

http://rawkes.com/ from bug 759629 is another good case for huge script labels due to long query strings. In this particular case however, the query string delimiter character '?' is missing, which confuses SS__trimUrlQuery. I'm not even sure such URLs are valid:

http://rawkes.com.woopra-ns.com/visit/ra=RTQE96Y6BFVTG8BQ9MQZE9CPAIC85Z39&cookie=R93U390OEXA93DSSGVQ166PUYBM8G9Q9&vid=-1&meta=MzYxNzI3JjMmNCYyMTMmMTMzODM2MjM1MjQ3MyYxMzM4MzYyOTk0MTc3JiYxMDAmJjImJiYm&alias=rawkes.com&language=en-US&page=%2F&pagetitle=Exploring%20the%20Frontiers%20of%20Online%20Media%20%7C%20Rawkes&referer=&screen=1920x1200&localtime=10%3A29

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #2)
> I'm not even sure such URLs are valid

Sometimes I'm surprised the whole internet thing even works...

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: v1

Works.

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: v1.1

I just realized that until now, the whole "for (let i = 0; i < vs._scripts.itemCount; i++)" check for script urls was incorrect, because there was no 1:1 relationship between the test urls array and the actual added urls in the dropdown. This means that, although it worked and the order wasn't important, not all the urls were tested. Fixed in this version.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 628301 [details] [diff] [review]
v1.1

Review of attachment 628301 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 7

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/fd76266dc5ca

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/fd76266dc5ca