746708 - Updates builder fails running backupsnip and pushsnip

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect, P1)

Description

[Rail Aliiev [:rail]]

Attachment: don't use bash

In 12.0b6 the updates builder failed running backupsnip:

retry: Calling <function run_with_timeout at 0xb7c790d4> with args: (['bash', '-c', 'ssh -t -l ffxbld -i ~/.ssh/auspush aus3-staging.mozilla.org ~/bin/backupsnip Firefox-12.0b6-build1-test'], 7260, None, None, False, True), kwargs: {}, attempt #1
Executing: ['bash', '-c', 'ssh -t -l ffxbld -i ~/.ssh/auspush aus3-staging.mozilla.org ~/bin/backupsnip Firefox-12.0b6-build1-test']
Pseudo-terminal will not be allocated because stdin is not a terminal.
bash: /home/cltbld/bin/backupsnip: No such file or directory

It turned out that ShellCommand interpolates ~ into /home/cltbld on a slave. Attached patch should fix the problem. To be tested.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

I think that patch might cause the ~/.ssh not be interpolated. If so, we could do
bash -c 'ssh -t -l ffxbld -i ~/.ssh/auspush aus3-staging.mozilla.org bin/backupsnip Firefox-12.0b6-build1-test'
ie drop the ~/ for backupsnip.

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 616252 [details] [diff] [review]
don't use bash

(In reply to Nick Thomas [:nthomas] from comment #1)
> I think that patch might cause the ~/.ssh not be interpolated. If so, we
> could do
> bash -c 'ssh -t -l ffxbld -i ~/.ssh/auspush aus3-staging.mozilla.org
> bin/backupsnip Firefox-12.0b6-build1-test'
> ie drop the ~/ for backupsnip.

-oIdentityFile=~/.ssh/... interpolates ~ internally, we use it in some places. The patch worked fine in staging. However, if you prefer "./bin/backupsnip" style, I'll prep/test another patch.

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 616252 [details] [diff] [review]
don't use bash

http://hg.mozilla.org/build/buildbotcustom/rev/460bb1e171a7

Comment 4

[Chris Cooper [:coop] (he/him)]

pushsnip failed the same way for Firefox 10.0.4esr:

http://buildbot-master08.build.sjc1.mozilla.com:8001/builders/release-mozilla-esr10-updates/builds/1/steps/pushsnip/logs/stdio

Patch should be the same as for backupsnip.

Comment 5

[Rail Aliiev [:rail]]

Attachment: pushsnip patch

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 617217 [details] [diff] [review]
pushsnip patch

http://hg.mozilla.org/build/buildbotcustom/rev/ce3520ea5ee1

Comment 7

[Rail Aliiev [:rail]]

Landed to production yesterday.