74672 - allow certain columns not to show in the column picker

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

right now, the column picker iterates of all the columns and uses "hidden" to
decide to show if the column is checked or not in the picker.

there are cases where I don't want all the columns to show in the picker.

(example:  search and thread pane, which uses the thread pane overlay) 

specifically, the thread, unread total, and thread total columns should not show
up in the column picker in the search dialog.

eventually, the "folder location" column (when we add it) should not show up in
the column picker in the thread pane.

I was thinking I could add another attribute ("inpicker") that if "false" cause
the js in outlinerBindings.xml to skip over and not add that column to the
picker.

hyatt, what do you think?

Comment 1

[Blake Ross]

This is a problem I encountered also with the columnpicker.  I got around it by 
using the collapsed attr (which is somewhat like a synonym of hidden) to 
mean "don't show this picker at all".  You can see this at 
http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/treePopups
.js#40.  I gave hyatt the code for the xblified version of the columnpicker for 
outliner, but it looks like he didn't use that part of it.

Comment 2

[David Hyatt]

I can't use collapsed, because it will actually collapse the column.

Comment 3

[Blake Ross]

Hmmm....good point :-)  It worked well for me because I had to hide the column 
as well (dynamically).

Comment 4

[(not reading, please use [e-mail] instead)]

I talked to hyatt, I'm going to use another attribute to accomplish what I need.

accepting

Comment 5

[(not reading, please use [e-mail] instead)]

the attribute will be ignoreincolumnpicker, so if you have ignoreinpicker="true"
it won't show up.

just waiting for a review from hyatt.

Comment 6

[(not reading, please use [e-mail] instead)]

s/ignoreincolumnpicker/ignoreinpicker

Comment 7

[(not reading, please use [e-mail] instead)]

ignoreincolumnpicker="true"

sorry for the confusion.

fixed.

Comment 8

[laurel]

Marking verified.