Last Comment Bug 746745 - [SeaMonkey] Space for moving to next unread doesn't work (JavaScript error: chrome://messenger/content/mailWindowOverlay.js, line 2311)
: [SeaMonkey] Space for moving to next unread doesn't work (JavaScript error: c...
Status: RESOLVED FIXED
: regression
Product: MailNews Core
Classification: Components
Component: Backend (show other bugs)
: Trunk
: All All
: -- major (vote)
: Thunderbird 14.0
Assigned To: Serge Gautherie (:sgautherie)
:
Mentors:
Depends on:
Blocks: 332151
  Show dependency treegraph
 
Reported: 2012-04-18 14:36 PDT by Karsten Düsterloh
Modified: 2012-04-20 12:16 PDT (History)
5 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
(Av1) Move 'mail.advance_on_spacebar' preference from mail/ to mailnews/ [Checked in: Comment 5] (1.93 KB, patch)
2012-04-20 01:41 PDT, Serge Gautherie (:sgautherie)
standard8: review+
Details | Diff | Splinter Review

Description Karsten Düsterloh 2012-04-18 14:36:19 PDT
JavaScript error: chrome://messenger/content/mailWindowOverlay.js, line 2311: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]

when hitting space to move to next unread message - and no message switching happens. Obviously, the pref mail.advance_on_spacebar lacks a default value in SeaMonkey.

This is caused by the Thunderbird bug 332151.
Comment 1 Rahul Abrol 2012-04-19 23:50:47 PDT
sorry about that.  you're all undoubtedly more familiar with the code base than i am so i'll leave the patch to you.
Comment 2 Serge Gautherie (:sgautherie) 2012-04-20 01:41:18 PDT
Created attachment 616902 [details] [diff] [review]
(Av1) Move 'mail.advance_on_spacebar' preference from mail/ to mailnews/
[Checked in: Comment 5]
Comment 3 Blake Winton (:bwinton) (:☕️) 2012-04-20 11:21:55 PDT
Comment on attachment 616902 [details] [diff] [review]
(Av1) Move 'mail.advance_on_spacebar' preference from mail/ to mailnews/
[Checked in: Comment 5]

I _think_ this is okay, but Standard8 is really the person who would know, so I'm redirecting the review request his way.

Thanks,
Blake.
Comment 4 Mark Banner (:standard8) 2012-04-20 11:25:45 PDT
Comment on attachment 616902 [details] [diff] [review]
(Av1) Move 'mail.advance_on_spacebar' preference from mail/ to mailnews/
[Checked in: Comment 5]

Looks fine.
Comment 5 Serge Gautherie (:sgautherie) 2012-04-20 12:15:17 PDT
Comment on attachment 616902 [details] [diff] [review]
(Av1) Move 'mail.advance_on_spacebar' preference from mail/ to mailnews/
[Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/b8a4823c1ca3

Note You need to log in before you can comment on or make changes to this bug.