746778 - Fennec crashes on x86/Android. Error: relocation to NULL @0x0002ef10 for symbol "_PR_x86_AtomicSet"

Status: RESOLVED DUPLICATE of bug 693329

(NSPR :: NSPR, defect)

Description

[Thomas G Eaton]

Attachment: logcat_relocation_NULL_prx86atomicset.txt

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
Build ID: 20111008085652

Steps to reproduce:

I built Fennec from the trunk for x86/Android and then installed and tried to run it on an x86 Android tablet.  


Actual results:

It crashed after loading the start screen.  Attached is the logcat of the crash.

Comment 1

[Mike Hommey [:glandium]]

Can you attach this libnspr4.so ?

Comment 2

[Thomas G Eaton]

Attachment: libnspr4.so from the build

Comment 3

[Mike Hommey [:glandium]]

(In reply to Thomas G Eaton from comment #2)
> Created attachment 617092 [details]
> libnspr4.so from the build

That's what I thought. There is something wrong in your nspr build, and libnspr4.so doesn't contain the _PR_x86_AtomicSet symbol, which it should contain.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Share Android and Linux definitions in configure.in, to avoid anything unexpectedly missing for Android

Comment 5

[Mike Hommey [:glandium]]

Note: if necessary, we can work around the issue in mozilla-central until the nspr change lands there (which could take some time), if that would make things smoother for you.

Comment 6

[Thomas G Eaton]

After looking at your patch, I remembered a fix in this area that I thought had already been checked in.  693329 should address this issue shouldn't it?  If that change is still waiting to go in, then this can be marked as a duplicate.  Is the fix from that bug still waiting to be merged somewhere?

Comment 7

[Thomas G Eaton]

Actual bug link. https://bugzilla.mozilla.org/show_bug.cgi?id=693329

Comment 8

[Mike Hommey [:glandium]]

Indeed this is the same issue, and we're still on NSPR 4.9 on mozilla-central, so until 4.9.1 or newer lands, you'll have the problem. So, either we work around the issue in m-c, or we land 4.9.x. Ted, any opinion?

Also note that the patch from bug 693329 is not very future-proof, but it's another matter.

Comment 9

[Mike Hommey [:glandium]]

Attachment: Fix bug 693329 without waiting for a NSPR release

Comment 10

[Thomas G Eaton]

I tested attachment 617818 [details] [diff] [review] and it works to resolve the issue.  Thanks.

Comment 11

[(not currently active) Ted Mielczarek]

Comment on attachment 617818 [details] [diff] [review]
Fix bug 693329 without waiting for a NSPR release

Review of attachment 617818 [details] [diff] [review]:
-----------------------------------------------------------------

This is kind of ugly. Is there any reason we shouldn't just go ahead and get an NSPR release done? This is only for Android/x86, right? Doesn't seem important enough to warrant putting in hacks when we already have an NSPR fix.

Comment 12

[Wan-Teh Chang]

Comment on attachment 617399 [details] [diff] [review]
Share Android and Linux definitions in configure.in, to avoid anything unexpectedly missing for Android

r=wtc.

We can make a new NSPR release for this bug fix.

Comment 13

[Wan-Teh Chang]

I will check in Mike Hommey's first patch.