746868 - Some subtests in test_doc.html fail with Bug 695480

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Test disabling

See the attached patch for the three failures.

Comment 1

[Marco Zehe (:MarcoZ)]

So what exactly does bug 695480 do that makes these tests fail? I'm strictly against just disabling these tests since this is an indication that something may break us (and therefore screen readers) because of the patch in that bug.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Bug 695480 makes it so that you can't touch DOM objects in a Window (including nodes, etc) after the Window is navigated.  I'm not sure whether the bugs here are in the test or in the browser UI somewhere.  Unfortunately I can't really figure out what the tests are testing, so I was hoping someone on the a11y team could dig in here.

Comment 3

[Marco Zehe (:MarcoZ)]

The tests perform all sorts of mutations on a document inside an iframe. The first of the ones that you disabled opens a new doc inside an iframe and tests whether the accessible tree built from the resulting DOM tree is what we expected, and if certain events are fired before testing that tree. The next one closes that same thing and checks whether afterwards, the tree conforms to the new expectations, mainly that the contents is gone. And the last test youdisabled tests whether content gets provided correctly if nodes are inserted without the document actually having a body element.

Comment 4

[alexander :surkov (:asurkov)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #2)
> Bug 695480 makes it so that you can't touch DOM objects in a Window
> (including nodes, etc) after the Window is navigated.

Could you give JS example?

>  I'm not sure whether
> the bugs here are in the test or in the browser UI somewhere.  Unfortunately
> I can't really figure out what the tests are testing, so I was hoping
> someone on the a11y team could dig in here.

failure log please?

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to alexander :surkov from comment #4)
> (In reply to Kyle Huey [:khuey] ([e-mail]) from comment #2)
> > Bug 695480 makes it so that you can't touch DOM objects in a Window
> > (including nodes, etc) after the Window is navigated.
> 
> Could you give JS example?

Sure:

let win = window.open();
let documentElement = win.document.documentElement;
win.close();
documentElement.nodeType; // This now throws, because you can't touch things inside the window after it is closed.

> >  I'm not sure whether
> > the bugs here are in the test or in the browser UI somewhere.  Unfortunately
> > I can't really figure out what the tests are testing, so I was hoping
> > someone on the a11y team could dig in here.
> 
> failure log please?

The failure mode is just a timeout.

Comment 6

[alexander :surkov (:asurkov)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #5)
> > failure log please?
> The failure mode is just a timeout.

the log contains some extra info (it shows which test timed out) but please add
gA11yEventDumpToConsole = true;
to test_doc.html to log more details.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Running test_doc.html: http://khuey.pastebin.mozilla.org/1593587

Comment 8

[alexander :surkov (:asurkov)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #7)
> Running test_doc.html: http://khuey.pastebin.mozilla.org/1593587

thank you. I can't spot anything evident in events.js why events comparison could fail (we just compare pointers to accessible objects) so I'm going to make a local build with bug 695480 patch applied to see what happens.

Comment 9

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 10

[alexander :surkov (:asurkov)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #5)
> (In reply to alexander :surkov from comment #4)
> > (In reply to Kyle Huey [:khuey] ([e-mail]) from comment #2)
> > > Bug 695480 makes it so that you can't touch DOM objects in a Window
> > > (including nodes, etc) after the Window is navigated.
> > 
> > Could you give JS example?
> 
> Sure:
> 
> let win = window.open();
> let documentElement = win.document.documentElement;
> win.close();
> documentElement.nodeType; // This now throws, because you can't touch things
> inside the window after it is closed.

do I understand right, that's applicable to DOM node JS wrapper objects only?

Comment 11

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6071b7a2cb39

Comment 12

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Thanks for digging in here!

Comment 13

[alexander :surkov (:asurkov)]

yw!

Comment 14

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/6071b7a2cb39