Closed Bug 746951 Opened 10 years ago Closed 10 years ago

Avoid inlining js::MarkRangeConservatively with AddressSanitizer builds

Categories

(Core :: JavaScript Engine, defect)

All
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: decoder, Assigned: decoder)

Details

(Whiteboard: [asan][sg:want])

Attachments

(1 file)

The function js::MarkRangeConservatively is currently the only function in the JS garbage collector that produces a false positive when not blacklisted. The reason is that this function scans (and thereby touches) the stack, including the redzones that AddressSanitizer adds between stack variables. Therefore, this function has been blacklisted from the beginning, avoiding it to be instrumented at all.

However, there is a bug in how this blacklist works together with inlining: As soon as a blacklisted function is inlined, it is still instrumented because the inlining step happens before AddressSanitizer instruments the code. The best solution I can see right now is to forbid inlining this function when building with AddressSanitizer.

Therefore, I'll add a patch adds JS_NEVER_INLINE to the function when MOZ_ASAN is defined.
Attached patch PatchSplinter Review
Attachment #616531 - Flags: review?(wmccloskey)
Whiteboard: [asan][sg:want] → [asan][sg:want][autoland-try]
Whiteboard: [asan][sg:want][autoland-try] → [asan][sg:want][autoland-in-queue]
Autoland Patchset:
	Patches: 616531
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=bceb471aa567
Try run started, revision bceb471aa567. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=bceb471aa567
Try run for bceb471aa567 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=bceb471aa567
Results (out of 15 total builds):
    success: 15
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-bceb471aa567
Whiteboard: [asan][sg:want][autoland-in-queue] → [asan][sg:want]
Attachment #616531 - Flags: review?(wmccloskey) → review+
Comment on attachment 616531 [details] [diff] [review]
Patch

I'd like to order one landing, please :D
Attachment #616531 - Flags: checkin?(gary)
(In reply to Christian Holler (:decoder) from comment #4)
> Comment on attachment 616531 [details] [diff] [review]
> Patch
> 
> I'd like to order one landing, please :D

Approval is required even for mozilla-inbound now, till April 24. I could land on Birch without approval, but that will land only after April 24.

Please request for approval-mozilla-central? flag, and leave a comment with the reasons for your request.

ref https://wiki.mozilla.org/Tree_Rules#mozilla-central_.28Nightly_channel.29
Comment on attachment 616531 [details] [diff] [review]
Patch

This change is not part of any build (a=npotb), as they are only active when compiling with ASan (AddressSanitizer).
Attachment #616531 - Flags: approval-mozilla-central?
Comment on attachment 616531 [details] [diff] [review]
Patch

Sounds good, you can just land with a=npotb but I'll approve here anyway.
Attachment #616531 - Flags: approval-mozilla-central? → approval-mozilla-central+
Attachment #616531 - Flags: checkin?(gary) → checkin+
https://hg.mozilla.org/mozilla-central/rev/ba03257fab28
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.