Open Bug 746974 Opened 9 years ago Updated 5 months ago

Some hittest/ tests receive wrong deepest child on Mac

Categories

(Core :: Disability Access APIs, defect, P3)

x86_64
macOS
defect

Tracking

()

People

(Reporter: MarcoZ, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [mac2020_1][leave open])

Attachments

(1 file, 1 obsolete file)

The hittests don't make a difference between child and deepest child, they both require the list item, not the image or text leaf accessibles in the one particular test.
Attached patch Temporarily fix tests (obsolete) — Splinter Review
Looks like on Mac, the child and deepest child for these tests are the same, whereas on Win and Linux they're different.
Attachment #618311 - Flags: review?(surkov.alexander)
Comment on attachment 618311 [details] [diff] [review]
Temporarily fix tests

Review of attachment 618311 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/hittest/test_general.html
@@ +19,4 @@
>        var list = getAccessible("list");
>        var listitem = getAccessible("listitem");
>        var image = getAccessible("image");
> +      testChildAtPoint(list, 1, 1, listitem, MAC ? listitem : image.firstChild);

nope, it should be the same on all platforms. so either boundaries or tree problem. It's better to have todo for Mac and keep bug open.
Attachment #618311 - Flags: review?(surkov.alexander)
Summary: hittest/ tests expect direct accessible, not text leaves or the like as deepest child on Mac → Some hittest/ tests receive wrong deepest child on Mac
Attachment #618311 - Attachment is obsolete: true
Disabled test on Mac: http://hg.mozilla.org/integration/mozilla-inbound/rev/3c330e379fa3
Whiteboard: {leave open}
Sorry, push backed out for linux mochitest-other orange:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&onlyunstarred=1&rev=8cc13f37bc66
https://tbpl.mozilla.org/php/getParsedLog.php?id=11222399&tree=Mozilla-Inbound

{
4512 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/events/test_focus_listcontrols.xul | Error in test: proposed current item 'ml_tangerine' is already current
}

https://hg.mozilla.org/integration/mozilla-inbound/rev/922510fc28aa
Whiteboard: {leave open} → [leave open]
Whiteboard: [leave open] → [mac2020_1][leave open]

Currently still broken:
(1) test_general.html

FAIL Wrong deepest child accessible at the point (1, 1) of ['div@id="list" node', address: [object HTMLDivElement], role: list, address: 0x1371fa8e0] - got '['div@id="listitem" node', address: [object HTMLDivElement], role: listitem, name: 'img item', address: 0x1371fa9a0]', expected '['undefined node', address: [object Text], role: text leaf, name: 'img', address: 0x13e611700]'
SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:277:18
isObject@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:201:5
testChildAtPoint@chrome://mochitests/content/a11y/accessible/tests/mochitest/layout.js:36:11
doTest@chrome://mochitests/content/a11y/accessible/tests/mochitest/hittest/test_general.html:28:23
waitForImageMap@chrome://mochitests/content/a11y/accessible/tests/mochitest/events.js:164:5
doPreTest@chrome://mochitests/content/a11y/accessible/tests/mochitest/hittest/test_general.html:19:22
setTimeout handlerSimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:689:43
waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:177:14
setTimeout handler
SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:689:43
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:167:12
waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:173:9
setTimeout handlerSimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:689:43
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:167:12
waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:173:9
setTimeout handler
SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:689:43
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:167:12
waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:173:9
setTimeout handlerSimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:689:43
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:167:12
waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:173:9
setTimeout handler
SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:689:43
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:167:12
waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:173:9
setTimeout handlerSimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:689:43
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:167:12
waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:173:9
setTimeout handler
SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:689:43
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:167:12
focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67

(2) test_zoom.html

FAIL Wrong deepest child of [ 'document node', address: [object HTMLDocument] ] - got '['p node', address: [object HTMLParagraphElement], role: paragraph, address: 0x13632f3a0]', expected '['undefined node', address: [object Text], role: text leaf, name: 'para 1', address: 0x1363b7d40]'
SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:277:18
isObject@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:201:5
hitTest@chrome://mochitests/content/a11y/accessible/tests/mochitest/layout.js:58:11
doTest@chrome://mochitests/content/a11y/accessible/tests/mochitest/hittest/test_zoom.html:26:14
setTimeout handlerSimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:689:43
waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:177:14
setTimeout handler
SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:689:43
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:167:12
focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67
FAIL Wrong deepest child of [ 'document node', address: [object HTMLDocument] ] - got '['p node', address: [object HTMLParagraphElement], role: paragraph, address: 0x1370f5c40]', expected '['undefined node', address: [object Text], role: text leaf, name: 'para 2', address: 0x1370f4980]'
SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:277:18
isObject@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:201:5
hitTest@chrome://mochitests/content/a11y/accessible/tests/mochitest/layout.js:58:11
doTest@chrome://mochitests/content/a11y/accessible/tests/mochitest/hittest/test_zoom.html:27:14
setTimeout handlerSimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:689:43
waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:177:14
setTimeout handler
SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:689:43
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:167:12
focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67
FAIL Wrong deepest child of [ 'document node', address: [object HTMLDocument] ] - got '['p node', address: [object HTMLParagraphElement], role: paragraph, address: 0x13632f3a0]', expected '['undefined node', address: [object Text], role: text leaf, name: 'para 1', address: 0x1363b7d40]'
SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:277:18
isObject@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:201:5
hitTest@chrome://mochitests/content/a11y/accessible/tests/mochitest/layout.js:58:11
doTest@chrome://mochitests/content/a11y/accessible/tests/mochitest/hittest/test_zoom.html:31:14
setTimeout handlerSimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:689:43
waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:177:14
setTimeout handler
SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:689:43
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:167:12
focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67
FAIL Wrong deepest child of [ 'document node', address: [object HTMLDocument] ] - got '['p node', address: [object HTMLParagraphElement], role: paragraph, address: 0x1370f5c40]', expected '['undefined node', address: [object Text], role: text leaf, name: 'para 2', address: 0x1370f4980]'
SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:277:18
isObject@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:201:5
hitTest@chrome://mochitests/content/a11y/accessible/tests/mochitest/layout.js:58:11
doTest@chrome://mochitests/content/a11y/accessible/tests/mochitest/hittest/test_zoom.html:32:14
setTimeout handlerSimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:689:43
waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:177:14
setTimeout handler
SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:689:43
waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:167:12
focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67

Priority: -- → P3
Severity: normal → S3

Just tested again with similar results.

You need to log in before you can comment on or make changes to this bug.