unicode-bidi:plaintext is supposed to work on inline elements

RESOLVED FIXED in mozilla15

Status

()

Core
Layout: Text
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Aharon (Vladimir) Lanin, Assigned: smontagu)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

Trunk
mozilla15
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
When unicode-bidi:-moz-plaintext was originally implemented, the CSS Writing Modes Level 3 spec said that the plaintext value was not supposed to have any effect on inline elements. However, that changed some time ago. It currently states as follows:

This value behaves as ‘isolate’ except that for the purposes of the Unicode bidirectional algorithm, the base directionality of each bidi paragraph immediately contained by the element is determined not by the element's computed ‘direction’ as usual, but by following the heuristic in rules P2 and P3 of the Unicode bidirectional algorithm. An element immediately contains a bidi paragraph if the element itself, but none of its descendants, both contains the entire bidi paragraph and is either a block container or a bidi-isolating inline.

In other words, plaintext is supposed to bidi-isolate inline elements just like unicode-bidi:isolate, while giving each bidi paragraph bounded by the element its own base direction by the usual plaintext algorithm (just like it does for non-inline elements).
(Reporter)

Comment 1

5 years ago
Created attachment 616581 [details]
Test case 1
(Assignee)

Updated

5 years ago
Attachment #616581 - Attachment mime type: text/plain → text/html
(Assignee)

Comment 2

5 years ago
Created attachment 616639 [details] [diff] [review]
Patch
Assignee: nobody → smontagu
Attachment #616639 - Flags: review?(roc)
(Assignee)

Comment 3

5 years ago
Created attachment 616640 [details] [diff] [review]
The test as reftest
Attachment #616640 - Flags: review?(roc)
(Assignee)

Comment 4

5 years ago
Created attachment 616641 [details] [diff] [review]
Patch

The right diff this time
Attachment #616639 - Attachment is obsolete: true
Attachment #616639 - Flags: review?(roc)
Attachment #616641 - Flags: review?(roc)
(Reporter)

Comment 5

5 years ago
Created attachment 616701 [details]
Test case 2
(Reporter)

Comment 6

5 years ago
Created attachment 616702 [details]
Test case 3
(Reporter)

Comment 7

5 years ago
Created attachment 616703 [details]
Test case 4
(Reporter)

Comment 8

5 years ago
BTW, plaintext is only supposed to affect alignment when it is on a containing block.
(Reporter)

Updated

5 years ago
Blocks: 613154
(Reporter)

Updated

5 years ago
Attachment #616701 - Attachment mime type: text/plain → text/html
(Reporter)

Updated

5 years ago
Attachment #616702 - Attachment mime type: text/plain → text/html
(Reporter)

Updated

5 years ago
Attachment #616703 - Attachment mime type: text/plain → text/html
Attachment #616640 - Flags: review?(roc) → review+
Attachment #616641 - Flags: review?(roc) → review+
(Assignee)

Comment 9

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e48d32ee1a5b
https://hg.mozilla.org/integration/mozilla-inbound/rev/15a028a333d2
Flags: in-testsuite+
Target Milestone: --- → mozilla15
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/e48d32ee1a5b
https://hg.mozilla.org/mozilla-central/rev/15a028a333d2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
I've added a note in:
https://developer.mozilla.org/en-US/docs/CSS/unicode-bidi
https://developer.mozilla.org/en-US/docs/Firefox_15_for_developers
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.