The default bug view has changed. See this FAQ.

Fix libjingle linkage on mac

RESOLVED FIXED

Status

()

Core
WebRTC
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ekr, Assigned: ekr)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Fix for libjingle link errors
(Assignee)

Comment 1

5 years ago
Created attachment 616627 [details] [diff] [review]
Fix libjingle linkage
(Assignee)

Updated

5 years ago
Summary: Fix libjingle linkage → Fix libjingle linkage on mac
(Assignee)

Updated

5 years ago
Attachment #616627 - Flags: review?(rjesup)
What was referencing unixfilesystem?  And why did it/does it work on alder/default?

I'm loathe to make changes without knowing why...
(Assignee)

Comment 3

5 years ago
Here is the link error:

ld: warning: could not create compact unwind for _ffi_call_unix64: does not use RBP or RSP based frame
Undefined symbols for architecture x86_64:
  "vtable for talk_base::UnixFilesystem", referenced from:
      talk_base::UnixFilesystem::UnixFilesystem()in fileutils.o
  NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
  "cricket::DeviceManagerFactory::Create()", referenced from:
      cricket::ChannelManager::ChannelManager(talk_base::Thread*)in channelmanager.o
      cricket::ChannelManager::ChannelManager(talk_base::Thread*)in channelmanager.o

What makes you think it works on alder/default? This is alder/default I'm having the problem on.
Note that the included files differ between Mac and Linux here.
Because the builders have no trouble building alder/default.  That doesn't mean that it isn't wrong and should be fixed, but I just want to understand *why* it's different - XCode version?  OS version?  Extra stuff installed?  Different build options?

I'll note that probably the os_posix -> os_linux change I made in libjingle (line 412) is probably the cause of the problem.  I changed it because it was breaking win32, and I can't test mac easily.

Updated

5 years ago
Attachment #616627 - Flags: review?(rjesup) → review+
(Assignee)

Comment 5

5 years ago
Fixed in: http://hg.mozilla.org/projects/alder/rev/64431beeafbe
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.