Fix for libjingle link errors
Created attachment 616627 [details] [diff] [review]
Fix libjingle linkage
What was referencing unixfilesystem? And why did it/does it work on alder/default?
I'm loathe to make changes without knowing why...
Here is the link error:
ld: warning: could not create compact unwind for _ffi_call_unix64: does not use RBP or RSP based frame
Undefined symbols for architecture x86_64:
"vtable for talk_base::UnixFilesystem", referenced from:
NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
"cricket::DeviceManagerFactory::Create()", referenced from:
What makes you think it works on alder/default? This is alder/default I'm having the problem on.
Note that the included files differ between Mac and Linux here.
Because the builders have no trouble building alder/default. That doesn't mean that it isn't wrong and should be fixed, but I just want to understand *why* it's different - XCode version? OS version? Extra stuff installed? Different build options?
I'll note that probably the os_posix -> os_linux change I made in libjingle (line 412) is probably the cause of the problem. I changed it because it was breaking win32, and I can't test mac easily.
Fixed in: http://hg.mozilla.org/projects/alder/rev/64431beeafbe