Closed
Bug 747049
Opened 13 years ago
Closed 11 years ago
Sometimes after upload app name doesn't show up.
Categories
(Marketplace Graveyard :: Developer Pages, defect, P3)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: krupa.mozbugs, Unassigned)
References
Details
(Keywords: steps-wanted, Whiteboard: [incorrect_implementation])
Sometimes after upload app name doesn't show up. See http://cl.ly/3R1w1208411i3K1p0k2J
Updated•13 years ago
|
Assignee: nobody → cvan
Priority: -- → P1
Target Milestone: --- → 6.5.1
Comment 1•13 years ago
|
||
If anyone has reliable STR for this, holler at your boi.
Target Milestone: 6.5.1 → 6.5.2
Comment 2•13 years ago
|
||
(In reply to Chris Van Wiemeersch [:cvan] from comment #1)
> If anyone has reliable STR for this, holler at your boi.
++. ashort is going to try to reproduce but would be nice to have STR
Assignee: cvan → ashort
Comment 3•13 years ago
|
||
Only thing I can come up with is that the app name is translated, and so two inserts are required - one for the addon, one for the translation table. Running this in a transaction seems like the obvious thing.
Remind me why we don't run _all_ our requests in db transactions?
Comment 4•13 years ago
|
||
I tried putting all @write in a transaction, but caused errors. Until I've resolved that, feel free to put as many requests as you'd like into transactions.
Updated•13 years ago
|
Target Milestone: 6.5.2 → 6.5.4
Updated•13 years ago
|
Comment 5•13 years ago
|
||
https://github.com/mozilla/zamboni/commit/1a52be71ab0a6ff2f8ed6f2b6832bf0280f3972c
Evidently this change did not fix the problem. STR still lacking...
Comment 6•13 years ago
|
||
The fact that the Name shows up in the <input type="text" name="name"> but not in addon.name is the weird part. Anyone have any other ideas?
Comment 7•13 years ago
|
||
Can't reproduce this so kicking out of the milestone
Priority: P1 → --
Whiteboard: [needs STR]
Target Milestone: 2012-05-10 → ---
Comment 8•13 years ago
|
||
(In reply to Wil Clouser [:clouserw] from comment #7)
> Can't reproduce this so kicking out of the milestone
It's weird - I can reproduce this every few app submissions.
Steps to reproduce:
1) Submit a manifest: https://marketplace-dev.allizom.org/en-US/developers/submit/app/manifest
2) Reach step 3 (Details). And the app name is missing.
No other steps are necessary.
Things worth noting:
* If you click "Edit" the name appears in the "Name" field (http://i.imgur.com/h8wxL.png). The name is, however, missing in the <h2> heading and the breadcrumb.
* If you refresh the page, the name *does* appear and is totally fine.
Any hunches?
Comment 9•13 years ago
|
||
laggy read slave?
Comment 10•13 years ago
|
||
Allen, have you turned up anything on this? Do we know how often it happens?
marking p3 until those questions answered
Priority: -- → P3
Updated•13 years ago
|
Comment 11•13 years ago
|
||
This seems to happen ~73% of the time for me on -dev and production.
Updated•13 years ago
|
Assignee: ashort → mattbasta
Comment 12•13 years ago
|
||
I can't reproduce this on -dev or in production. Perhaps it's an admin-only issue?
Reporter | ||
Comment 13•13 years ago
|
||
(In reply to Matt Basta from comment #12)
> I can't reproduce this on -dev or in production. Perhaps it's an admin-only
> issue?
I don't think so. I have seen this happen on my non-admin accounts.
Comment 14•13 years ago
|
||
You wold not believe how often this happens.
http://cl.ly/image/1b0E0L2t3R0d
And, yes, I do think by talking about it so much will get it fixed. ;)
Comment 15•13 years ago
|
||
I have still never seen it.
I did have an issue in the api with accessing a model via Webapp.objects as opposed to Addon.objects. In the api I created a model and then returned the content to the client. When I did that, the name was empty. Switching it using a queryset based on Addon not Webapp worked
https://github.com/mozilla/zamboni/commit/8ad17430ac26a212a63d5b493758efeb660e2f2f
I'm guessing there's an issue with the proxy model and creating Webapps. Could be related to proxy models and the meta class dance in Addon.
Updated•13 years ago
|
Target Milestone: --- → 2012-07-27
Updated•13 years ago
|
Product: addons.mozilla.org → Marketplace
Target Milestone: 2012-07-26 → ---
Version: unspecified → 1.0
Updated•13 years ago
|
Target Milestone: --- → 2012-07-26
Comment 16•13 years ago
|
||
I can't seem to reproduce this on -dev in Firefox or Chrome anymore. I have some ideas on what might be causing it, but unless I can see it happening a few times, it's going to be hella hard to debug.
If anyone sees this happening on -dev, production, or even locally, please let me know ASAP.
Comment 17•13 years ago
|
||
(In reply to Matt Basta [:basta] from comment #16)
> I can't seem to reproduce this on -dev in Firefox or Chrome anymore. I have
> some ideas on what might be causing it, but unless I can see it happening a
> few times, it's going to be hella hard to debug.
>
> If anyone sees this happening on -dev, production, or even locally, please
> let me know ASAP.
In production right now: http://cl.ly/image/0Y351R0u1m1H
Comment 18•13 years ago
|
||
https://github.com/mozilla/zamboni/commit/15a844a
Fixed it. But this is by no means a proper fix. Keeping open until someone properly fixes this.
Comment 19•13 years ago
|
||
For good reading material: https://github.com/mozilla/zamboni/issues/359
Updated•13 years ago
|
Target Milestone: 2012-07-26 → ---
Comment 20•12 years ago
|
||
Bump!
Comment 21•12 years ago
|
||
(In reply to Chris Van Wiemeersch [:cvan] from comment #18)
> https://github.com/mozilla/zamboni/commit/15a844a
>
> Fixed it. But this is by no means a proper fix. Keeping open until someone
> properly fixes this.
What is the proper fix?
Assignee: mattbasta → nobody
No longer blocks: 766199
Comment 22•12 years ago
|
||
(In reply to Wil Clouser [:clouserw] from comment #21)
> What is the proper fix?
There's a bug in the L10n libraries somewhere. The fix would involve finding it and then dealing with it.
Comment 23•12 years ago
|
||
The latest comments make it sound like a workaround is in place so closing this bug.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 24•12 years ago
|
||
So I haven't seen this in a while, and I'm going to attribute it to robhudon's fix for the default_locale stuff. I think he unintentionally fixed an issue that was caused by badly setting the locale of translated text, which was then being immediately corrected after the first read. Props to robhudson for doing it right and fixing bugs without even trying.
Rest in peace, bug 747049
Comment 25•12 years ago
|
||
Verified as fixed in https://marketplace-dev.allizom.org/developers/submit/app/manifest on FF20 (Win 7)
This issue is no longer reproducible http://screencast.com/t/FNmF5k0qAh8 .
Closing bug.
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 26•12 years ago
|
||
This still happens on altdev, dev and prod.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Comment 27•12 years ago
|
||
Does that still happen now ? I've fixed a few bugs regarding nameless apps because of l10n so I believe this one should not happen anymore.
Flags: needinfo?(krupa.mozbugs)
Comment 28•12 years ago
|
||
I've just found out that there is a nameless app in Firefox Marketplace. Take a look at https://marketplace.firefox.com/app/mozilla-slovenija?src=search
You can see the screenshot here: http://shrani.si/f/u/qQ/ApNGTA7/noname.png
This could be the issue with l10n - default language is Slovenian.
Reporter | ||
Comment 29•12 years ago
|
||
I saw this last week in prod and will like to keep the bug open until we have reproducible STR. The test app I was using didn't have any unusual locale settings.
Flags: needinfo?(krupa.mozbugs)
Comment 30•11 years ago
|
||
I've spent quite some time looking at the translation code this past few months, and to me, the only way to reproduce it nowadays would be to somehow have a default_locale on an app that does not correspond to the translations we have in the database.
There used to be a couple bugs like this, but I don't think we have any more. If anyone has some time to play with this, try to find a way to have an app default_locale out of sync with the current translations, either at submit or updating time.
Comment 31•11 years ago
|
||
Krupa, have you seen this lately? I think Rob, Basta, and I fixed it with our celery fixes.
Updated•11 years ago
|
Keywords: steps-wanted
Whiteboard: [needs STR]
Updated•11 years ago
|
Flags: needinfo?(krupa.mozbugs)
Updated•11 years ago
|
Whiteboard: [incorrect_implementation]
Reporter | ||
Comment 32•11 years ago
|
||
I haven't seen this bug in a while.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 11 years ago
Flags: needinfo?(krupa.mozbugs)
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•