747049 - Sometimes after upload app name doesn't show up.

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: Developer Pages, defect, P3)

Description

[krupa raj[:krupa]]

Sometimes after upload app name doesn't show up. See http://cl.ly/3R1w1208411i3K1p0k2J

Comment 1

[Christopher Van Wiemeersch [:cvan]]

If anyone has reliable STR for this, holler at your boi.

Comment 2

[Wil Clouser [:clouserw]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #1)
> If anyone has reliable STR for this, holler at your boi.

++.  ashort is going to try to reproduce but would be nice to have STR

Comment 3

[Allen Short [:ashort]]

Only thing I can come up with is that the app name is translated, and so two inserts are required - one for the addon, one for the translation table. Running this in a transaction seems like the obvious thing.


Remind me why we don't run _all_ our requests in db transactions?

Comment 4

[Andy McKay]

I tried putting all @write in a transaction, but caused errors. Until I've resolved that, feel free to put as many requests as you'd like into transactions.

Comment 5

[Allen Short [:ashort]]

https://github.com/mozilla/zamboni/commit/1a52be71ab0a6ff2f8ed6f2b6832bf0280f3972c

Evidently this change did not fix the problem. STR still lacking...

Comment 6

[Christopher Van Wiemeersch [:cvan]]

The fact that the Name shows up in the <input type="text" name="name"> but not in addon.name is the weird part. Anyone have any other ideas?

Comment 7

[Wil Clouser [:clouserw]]

Can't reproduce this so kicking out of the milestone

Comment 8

[Christopher Van Wiemeersch [:cvan]]

(In reply to Wil Clouser [:clouserw] from comment #7)
> Can't reproduce this so kicking out of the milestone

It's weird - I can reproduce this every few app submissions.

Steps to reproduce:
1) Submit a manifest: https://marketplace-dev.allizom.org/en-US/developers/submit/app/manifest
2) Reach step 3 (Details). And the app name is missing.

No other steps are necessary.

Things worth noting:
* If you click "Edit" the name appears in the "Name" field (http://i.imgur.com/h8wxL.png). The name is, however, missing in the <h2> heading and the breadcrumb.
* If you refresh the page, the name *does* appear and is totally fine.

Any hunches?

Comment 9

[Wil Clouser [:clouserw]]

laggy read slave?

Comment 10

[Wil Clouser [:clouserw]]

Allen, have you turned up anything on this?  Do we know how often it happens?

marking p3 until those questions answered

Comment 11

[Christopher Van Wiemeersch [:cvan]]

This seems to happen ~73% of the time for me on -dev and production.

Comment 12

[Matt Basta [:basta]]

I can't reproduce this on -dev or in production. Perhaps it's an admin-only issue?

Comment 13

[krupa raj[:krupa]]

(In reply to Matt Basta from comment #12)
> I can't reproduce this on -dev or in production. Perhaps it's an admin-only
> issue?

I don't think so. I have seen this happen on my non-admin accounts.

Comment 14

[Christopher Van Wiemeersch [:cvan]]

You wold not believe how often this happens.

http://cl.ly/image/1b0E0L2t3R0d

And, yes, I do think by talking about it so much will get it fixed. ;)

Comment 15

[Andy McKay]

I have still never seen it. 

I did have an issue in the api with accessing a model via Webapp.objects as opposed to Addon.objects. In the api I created a model and then returned the content to the client. When I did that, the name was empty. Switching it using a queryset based on Addon not Webapp worked 

https://github.com/mozilla/zamboni/commit/8ad17430ac26a212a63d5b493758efeb660e2f2f

I'm guessing there's an issue with the proxy model and creating Webapps. Could be related to proxy models and the meta class dance in Addon.

Comment 16

[Matt Basta [:basta]]

I can't seem to reproduce this on -dev in Firefox or Chrome anymore. I have some ideas on what might be causing it, but unless I can see it happening a few times, it's going to be hella hard to debug.

If anyone sees this happening on -dev, production, or even locally, please let me know ASAP.

Comment 17

[Christopher Van Wiemeersch [:cvan]]

(In reply to Matt Basta [:basta] from comment #16)
> I can't seem to reproduce this on -dev in Firefox or Chrome anymore. I have
> some ideas on what might be causing it, but unless I can see it happening a
> few times, it's going to be hella hard to debug.
> 
> If anyone sees this happening on -dev, production, or even locally, please
> let me know ASAP.

In production right now: http://cl.ly/image/0Y351R0u1m1H

Comment 18

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/15a844a 

Fixed it. But this is by no means a proper fix. Keeping open until someone properly fixes this.

Comment 19

[Christopher Van Wiemeersch [:cvan]]

For good reading material: https://github.com/mozilla/zamboni/issues/359

Comment 20

[Christopher Van Wiemeersch [:cvan]]

Bump!

Comment 21

[Wil Clouser [:clouserw]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #18)
> https://github.com/mozilla/zamboni/commit/15a844a 
> 
> Fixed it. But this is by no means a proper fix. Keeping open until someone
> properly fixes this.

What is the proper fix?

Comment 22

[Matt Basta [:basta]]

(In reply to Wil Clouser [:clouserw] from comment #21)
> What is the proper fix?

There's a bug in the L10n libraries somewhere. The fix would involve finding it and then dealing with it.

Comment 23

[Wil Clouser [:clouserw]]

The latest comments make it sound like a workaround is in place so closing this bug.

Comment 24

[Matt Basta [:basta]]

So I haven't seen this in a while, and I'm going to attribute it to robhudon's fix for the default_locale stuff. I think he unintentionally fixed an issue that was caused by badly setting the locale of translated text, which was then being immediately corrected after the first read. Props to robhudson for doing it right and fixing bugs without even trying.

Rest in peace, bug 747049

Comment 25

[Cristian Boldan]

Verified as fixed in https://marketplace-dev.allizom.org/developers/submit/app/manifest on FF20 (Win 7)
This issue is no longer reproducible http://screencast.com/t/FNmF5k0qAh8 .
Closing bug.

Comment 26

[krupa raj[:krupa]]

This still happens on altdev, dev and prod.

Comment 27

[Mathieu Pillard [:mat]]

Does that still happen now ? I've fixed a few bugs regarding nameless apps because of l10n so I believe this one should not happen anymore.

Comment 28

[Nino Vranešič [:elnino]]

I've just found out that there is a nameless app in Firefox Marketplace. Take a look at https://marketplace.firefox.com/app/mozilla-slovenija?src=search 

You can see the screenshot here: http://shrani.si/f/u/qQ/ApNGTA7/noname.png

This could be the issue with l10n - default language is Slovenian.

Comment 29

[krupa raj[:krupa]]

I saw this last week in prod and will like to keep the bug open until we have reproducible STR. The test app I was using didn't have any unusual locale settings.

Comment 30

[Mathieu Pillard [:mat]]

I've spent quite some time looking at the translation code this past few months, and to me, the only way to reproduce it nowadays would be to somehow have a default_locale on an app that does not correspond to the translations we have in the database.

There used to be a couple bugs like this, but I don't think we have any more. If anyone has some time to play with this, try to find a way to have an app default_locale out of sync with the current translations, either at submit or updating time.

Comment 31

[Christopher Van Wiemeersch [:cvan]]

Krupa, have you seen this lately? I think Rob, Basta, and I fixed it with our celery fixes.

Comment 32

[krupa raj[:krupa]]

I haven't seen this bug in a while.