Update the identity icons to have a darker lock icon for HTTPS and greener lock icon for HTTPS+EV.

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: curtisk, Assigned: jaws)

Tracking

Trunk
Firefox 15
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [SecReview Action Item][blocks FF15], URL)

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
Blocks: 742419
No longer blocks: 744304

Updated

5 years ago
Component: Security Assurance → Theme
Product: mozilla.org → Firefox
QA Contact: security-assurance → theme
Version: other → Trunk
Blocks: 744304

Comment 1

5 years ago
If only for consistency and to maintain muscle memory us users could have developed, please make it so it matches the blue hue of "basic identity information 'Larry'"[1].

I've yet to decide if I'd like a gray padlock for broken/faulty HTTPS, but I definitely believe good non-EV HTTPS should still give a visual clue (i.e. blue hue matching "Larry")

My 2¢

[1] https://support.mozilla.org/en-US/kb/Site%20Identity%20Button#w_blue-basic-identity-information
Created attachment 622509 [details] [diff] [review]
Patch for bug

This swaps out the current lock images with newer/darker ones provided by Stephen.
Attachment #622509 - Flags: review?(mnoorenberghe+bmo)
Comment on attachment 622509 [details] [diff] [review]
Patch for bug

Whoops, some extra crud got picked up in the qref.
Attachment #622509 - Attachment is obsolete: true
Attachment #622509 - Flags: review?(mnoorenberghe+bmo)
Created attachment 622511 [details] [diff] [review]
Patch for bug
Attachment #622511 - Flags: review?(mnoorenberghe+bmo)
Is this icon sufficiently visible on dark backgrounds?
Yes, see this screenshot for an example using High Contrast #2 http://screencast.com/t/v2AT5mMe
Created attachment 622545 [details] [diff] [review]
Patch for bug

Also added in the new green lock icons from Stephen.
Attachment #622511 - Attachment is obsolete: true
Attachment #622511 - Flags: review?(mnoorenberghe+bmo)
Attachment #622545 - Flags: review?(mnoorenberghe+bmo)
Summary: Make the lock icon darker for the non-ev case → Update the identity icons to have a darker lock icon for HTTPS and greener lock icon for HTTPS+EV.
Comment on attachment 622545 [details] [diff] [review]
Patch for bug

What is the next step on this bug? Do we still want to do this?
Attachment #622545 - Flags: review?(mnoorenberghe+bmo) → feedback?(shorlander)
Comment on attachment 622545 [details] [diff] [review]
Patch for bug

Sorry, that comment was meant for a different bug.
Attachment #622545 - Flags: feedback?(shorlander) → review?(felipc)
Attachment #622545 - Flags: review?(felipc) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4658a6aa237e
Flags: in-testsuite-
Target Milestone: --- → Firefox 15
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/4658a6aa237e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.