Closed Bug 747083 Opened 12 years ago Closed 12 years ago

Update the identity icons to have a darker lock icon for HTTPS and greener lock icon for HTTPS+EV.

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 15

People

(Reporter: curtisk, Assigned: jaws)

References

(
URL
)

Details

(Whiteboard: [SecReview Action Item][blocks FF15])

Attachments

(1 file, 2 obsolete files)

Patch for bug
6.47 KB, patch
Felipe
: review+
Details | Diff | Splinter Review 
      No description provided.
Blocks: 742419
No longer blocks: 744304
Component: Security Assurance → Theme
Product: mozilla.org → Firefox
QA Contact: security-assurance → theme
Version: other → Trunk
If only for consistency and to maintain muscle memory us users could have developed, please make it so it matches the blue hue of "basic identity information 'Larry'"[1].

I've yet to decide if I'd like a gray padlock for broken/faulty HTTPS, but I definitely believe good non-EV HTTPS should still give a visual clue (i.e. blue hue matching "Larry")

My 2¢

[1] https://support.mozilla.org/en-US/kb/Site%20Identity%20Button#w_blue-basic-identity-information
Attached patch Patch for bug (obsolete) — — Splinter Review 
This swaps out the current lock images with newer/darker ones provided by Stephen.
Attachment #622509 - Flags: review?(mnoorenberghe+bmo)
Comment on attachment 622509 [details] [diff] [review]
Patch for bug

Whoops, some extra crud got picked up in the qref.
Attachment #622509 - Attachment is obsolete: true
Attachment #622509 - Flags: review?(mnoorenberghe+bmo)
Attached patch Patch for bug (obsolete) — — Splinter Review 

        Attachment #622511 -
        Flags: review?(mnoorenberghe+bmo)

    
    

    
  
Is this icon sufficiently visible on dark backgrounds?

    
    

    
  
Yes, see this screenshot for an example using High Contrast #2 http://screencast.com/t/v2AT5mMe

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch for bug
        — 
          — Splinter Review
      

    


  
Also added in the new green lock icons from Stephen.

        Attachment #622511 -
        Attachment is obsolete: true

        Attachment #622511 -
        Flags: review?(mnoorenberghe+bmo)

        Attachment #622545 -
        Flags: review?(mnoorenberghe+bmo)
Summary: Make the lock icon darker for the non-ev case → Update the identity icons to have a darker lock icon for HTTPS and greener lock icon for HTTPS+EV.

    
    

    
  
Comment on attachment 622545 [details] [diff] [review]
Patch for bug

What is the next step on this bug? Do we still want to do this?

        Attachment #622545 -
        Flags: review?(mnoorenberghe+bmo) → feedback?(shorlander)

    
    

    
  
Comment on attachment 622545 [details] [diff] [review]
Patch for bug

Sorry, that comment was meant for a different bug.

        Attachment #622545 -
        Flags: feedback?(shorlander) → review?(felipc)

        Attachment #622545 -
        Flags: review?(felipc) → review+

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/4658a6aa237e
Flags: in-testsuite-
Target Milestone: --- → Firefox 15
Status: NEW → ASSIGNED

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/4658a6aa237e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: