Last Comment Bug 747083 - Update the identity icons to have a darker lock icon for HTTPS and greener lock icon for HTTPS+EV.
: Update the identity icons to have a darker lock icon for HTTPS and greener lo...
Status: RESOLVED FIXED
[SecReview Action Item][blocks FF15]
:
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All All
: -- normal with 1 vote (vote)
: Firefox 15
Assigned To: Jared Wein [:jaws] (please needinfo? me)
:
Mentors:
https://wiki.mozilla.org/Security/Rev...
Depends on:
Blocks: 742419 744304
  Show dependency treegraph
 
Reported: 2012-04-19 11:08 PDT by Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]
Modified: 2012-05-15 06:46 PDT (History)
14 users (show)
jaws: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch for bug (5.11 KB, patch)
2012-05-09 14:10 PDT, Jared Wein [:jaws] (please needinfo? me)
no flags Details | Diff | Splinter Review
Patch for bug (3.22 KB, patch)
2012-05-09 14:18 PDT, Jared Wein [:jaws] (please needinfo? me)
no flags Details | Diff | Splinter Review
Patch for bug (6.47 KB, patch)
2012-05-09 15:35 PDT, Jared Wein [:jaws] (please needinfo? me)
felipc: review+
Details | Diff | Splinter Review

Description Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]] 2012-04-19 11:08:30 PDT

    
Comment 1 alex_mayorga 2012-04-25 06:49:52 PDT
If only for consistency and to maintain muscle memory us users could have developed, please make it so it matches the blue hue of "basic identity information 'Larry'"[1].

I've yet to decide if I'd like a gray padlock for broken/faulty HTTPS, but I definitely believe good non-EV HTTPS should still give a visual clue (i.e. blue hue matching "Larry")

My 2¢

[1] https://support.mozilla.org/en-US/kb/Site%20Identity%20Button#w_blue-basic-identity-information
Comment 2 Jared Wein [:jaws] (please needinfo? me) 2012-05-09 14:10:54 PDT
Created attachment 622509 [details] [diff] [review]
Patch for bug

This swaps out the current lock images with newer/darker ones provided by Stephen.
Comment 3 Jared Wein [:jaws] (please needinfo? me) 2012-05-09 14:14:48 PDT
Comment on attachment 622509 [details] [diff] [review]
Patch for bug

Whoops, some extra crud got picked up in the qref.
Comment 4 Jared Wein [:jaws] (please needinfo? me) 2012-05-09 14:18:45 PDT
Created attachment 622511 [details] [diff] [review]
Patch for bug
Comment 5 Dão Gottwald [:dao] 2012-05-09 14:29:50 PDT
Is this icon sufficiently visible on dark backgrounds?
Comment 6 Jared Wein [:jaws] (please needinfo? me) 2012-05-09 15:06:47 PDT
Yes, see this screenshot for an example using High Contrast #2 http://screencast.com/t/v2AT5mMe
Comment 7 Jared Wein [:jaws] (please needinfo? me) 2012-05-09 15:35:37 PDT
Created attachment 622545 [details] [diff] [review]
Patch for bug

Also added in the new green lock icons from Stephen.
Comment 8 Jared Wein [:jaws] (please needinfo? me) 2012-05-12 15:45:43 PDT
Comment on attachment 622545 [details] [diff] [review]
Patch for bug

What is the next step on this bug? Do we still want to do this?
Comment 9 Jared Wein [:jaws] (please needinfo? me) 2012-05-12 15:47:32 PDT
Comment on attachment 622545 [details] [diff] [review]
Patch for bug

Sorry, that comment was meant for a different bug.
Comment 10 Jared Wein [:jaws] (please needinfo? me) 2012-05-14 13:17:09 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/4658a6aa237e
Comment 11 Ed Morley [:emorley] 2012-05-15 06:46:11 PDT
https://hg.mozilla.org/mozilla-central/rev/4658a6aa237e

Note You need to log in before you can comment on or make changes to this bug.