Closed
Bug 747083
Opened 14 years ago
Closed 14 years ago
Update the identity icons to have a darker lock icon for HTTPS and greener lock icon for HTTPS+EV.
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 15
People
(Reporter: curtisk, Assigned: jaws)
References
()
Details
(Whiteboard: [SecReview Action Item][blocks FF15])
Attachments
(1 file, 2 obsolete files)
|
6.47 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Updated•14 years ago
|
Component: Security Assurance → Theme
Product: mozilla.org → Firefox
QA Contact: security-assurance → theme
Version: other → Trunk
|
||
Comment 1•14 years ago
|
||
If only for consistency and to maintain muscle memory us users could have developed, please make it so it matches the blue hue of "basic identity information 'Larry'"[1].
I've yet to decide if I'd like a gray padlock for broken/faulty HTTPS, but I definitely believe good non-EV HTTPS should still give a visual clue (i.e. blue hue matching "Larry")
My 2¢
[1] https://support.mozilla.org/en-US/kb/Site%20Identity%20Button#w_blue-basic-identity-information
|
Assignee | |
Comment 2•14 years ago
|
||
This swaps out the current lock images with newer/darker ones provided by Stephen.
Attachment #622509 -
Flags: review?(mnoorenberghe+bmo)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 622509 [details] [diff] [review]
Patch for bug
Whoops, some extra crud got picked up in the qref.
Attachment #622509 -
Attachment is obsolete: true
Attachment #622509 -
Flags: review?(mnoorenberghe+bmo)
|
|
Assignee | |
Comment 4•14 years ago
|
||
Attachment #622511 -
Flags: review?(mnoorenberghe+bmo)
|
|
||
Comment 5•14 years ago
|
||
Is this icon sufficiently visible on dark backgrounds?
|
|
Assignee | |
Comment 6•14 years ago
|
||
Yes, see this screenshot for an example using High Contrast #2 http://screencast.com/t/v2AT5mMe
|
|
Assignee | |
Comment 7•14 years ago
|
||
Also added in the new green lock icons from Stephen.
Attachment #622511 -
Attachment is obsolete: true
Attachment #622511 -
Flags: review?(mnoorenberghe+bmo)
Attachment #622545 -
Flags: review?(mnoorenberghe+bmo)
|
|
Assignee | |
Updated•14 years ago
|
Summary: Make the lock icon darker for the non-ev case → Update the identity icons to have a darker lock icon for HTTPS and greener lock icon for HTTPS+EV.
|
|
Assignee | |
Comment 8•14 years ago
|
||
Comment on attachment 622545 [details] [diff] [review]
Patch for bug
What is the next step on this bug? Do we still want to do this?
Attachment #622545 -
Flags: review?(mnoorenberghe+bmo) → feedback?(shorlander)
|
|
Assignee | |
Comment 9•14 years ago
|
||
Comment on attachment 622545 [details] [diff] [review]
Patch for bug
Sorry, that comment was meant for a different bug.
Attachment #622545 -
Flags: feedback?(shorlander) → review?(felipc)
|
||
Updated•14 years ago
|
Attachment #622545 -
Flags: review?(felipc) → review+
|
|
Assignee | |
Comment 10•14 years ago
|
||
Flags: in-testsuite-
Target Milestone: --- → Firefox 15
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 11•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•