747085 - Make the https:// green in the https ev case

Status: RESOLVED WONTFIX

(Firefox :: Address Bar, defect)

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for bug

This patch makes https:// green when visiting a site using SSL-EV. The color that is used here is the same color that is used in the patch for bug 747608.

I don't know of a system color for green text, so I'm not sure how we can handle different OS themes/accessibility modes. Should we just disable the special coloring in these cases?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Tests for patch

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 621240 [details] [diff] [review]
Patch for bug

Review of attachment 621240 [details] [diff] [review]:
-----------------------------------------------------------------

Why would we need to disable this? URLSECONDARY is already hardcoded to black so assumptions about the color of the URL bar are already baked in.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #3)
> URLSECONDARY is already hardcoded to black

No, it's based on the text color.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 621240 [details] [diff] [review]
Patch for bug

some points:

- this makes the protocol green based on the current site's identity even if the location bar value is modified

- a11y and dark OS themes are a concern; not sure what we'd do about this

- I think we probably shouldn't make this change at all. We should have one clear indicator that the user can click to get more information. If what we have isn't clear enough, we should fix that rather than adding other vague hints without contextual information.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for bug v2

(In reply to Dão Gottwald [:dao] from comment #5)
> - this makes the protocol green based on the current site's identity even if
> the location bar value is modified

This has been fixed in this version of the patch.

> - a11y and dark OS themes are a concern; not sure what we'd do about this

I changed the patch to no longer use the green color if there is a lightweight theme or non-default Windows theme enabled.

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 622127 [details] [diff] [review]
Patch for bug v2

I still think we shouldn't do this.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 622127 [details] [diff] [review]
Patch for bug v2

What is the next step for this? Do we still want to do this, or should we mark this bug as WONTFIX?

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Marking this as WONTFIX due to lack of feedback/replies on this bug.

If our current security indicator isn't doing a good enough job at letting users know that they are on HTTPS then we should fix the security indicator.

Making HTTPS green in the location bar can confuse users as to where to click to activate the identity doorhanger.