747109 - "Clear Private Data" throws an error and fails to clear some data

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: part 1: Remove broken nsIBrowserHistory code

Originally reported in bug 747067 comment 3.

Steps to reproduce:  Tap on "Clear Private Data" in the Fennec settings.

Expected results: No errors; session history and general.open_location.last_url are cleared.
Actual results: Session history and last_url pref are *not* cleared; the following error appears in the log:

E/GeckoConsole( 7288): Error sanitizing history: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: chrome://browser/content/sanitize.js :: <TOP_LEVEL> :: line 185"  data: no]

nsNavHistory::Init is returning an error, because it can't initialize the places database, because MOZ_ANDROID_HISTORY disables it.  Since we don't use the the history service in Fennec, we can just remove this code.  (Alternately, we could wrap it in a try/catch block in case so it will run if we ever re-enable Places in a future version.)

Nominating for blocking-fennec1.0 because this has a (minor) privacy impact and the fix just requires removing some unused and broken code.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

related bugs : bug 747067, bug 746946 ?

Comment 2

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8e1b554c7f8

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e8e1b554c7f8

Comment 4

[Andreea Pod]

There are no errors in the console when I hit Clear private data. The session history is cleared. 

Marking this as verified fixed on: Firefox 15.0a1 (2012-05-20)
Device: LG Optimus 2X (Android 2.2.2)