Closed
Bug 747180
Opened 12 years ago
Closed 12 years ago
remove --testDate and --useID from talos perfconfigurator
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmuel11)
Details
(Whiteboard: [good first bug][mentor=BYK][lang=py])
Attachments
(2 files, 2 obsolete files)
3.70 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
4.63 KB,
patch
|
Details | Diff | Splinter Review |
in talos, we don't seem to be using the testDate variable. This is configured in PerfConfigurator as --testDate and --useID. There are various calls and functions to support this functionality.
Reporter | ||
Updated•12 years ago
|
Whiteboard: [mentor=BYK] → [good first bug][mentor=BYK][lang=py]
Assignee | ||
Comment 1•12 years ago
|
||
I can take a look at this.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → jmuel11
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #618836 -
Flags: review?(jhammel)
Comment 3•12 years ago
|
||
Comment on attachment 618836 [details] [diff] [review] First patch attempt Review of attachment 618836 [details] [diff] [review]: ----------------------------------------------------------------- Other than this minor question, LGTM. ::: talos/PerfConfigurator.py @@ +82,1 @@ > def _getTimeFromBuildId(self): Did you forget to remove this one or it is used elsewhere?
Attachment #618836 -
Flags: feedback+
Assignee | ||
Comment 4•12 years ago
|
||
That's related to --id, not --testDate or --useID. I don't think it's ever used but it's not related to this bug as far as I can tell.
Assignee | ||
Comment 5•12 years ago
|
||
Looking at it, though, --id seems like it was tied into the others and could be removed.
Comment 6•12 years ago
|
||
(In reply to James Mueller from comment #4) > That's related to --id, not --testDate or --useID. I don't think it's ever > used but it's not related to this bug as far as I can tell. You have removed self._getTimeFromBuildId() from 181st line(the old version) that's why I mentioned this ;)
Assignee | ||
Comment 7•12 years ago
|
||
That's because it references useId. If the consensus is that _getTimeFromBuildId needs to be removed then it's easy enough to do.
Reporter | ||
Comment 8•12 years ago
|
||
++ for removing the _getTimeFromBuildId function.
Comment 9•12 years ago
|
||
Comment on attachment 618836 [details] [diff] [review] First patch attempt Overall good, but as recommended please get rid of _getTimeFromBuildId. _getTime can also go as it is only used by _getTimeFromTimeStamp and _getTimeFromBuildId Going to r- this for now, but its mostly there! :) Thanks.
Attachment #618836 -
Flags: review?(jhammel) → review-
Comment 10•12 years ago
|
||
There's probably also cleanup in run_test, but we can take that in a separate bug
Comment 11•12 years ago
|
||
Hmmm, it also looks like buildid (-i, --id) isn't used at all after these are removed. Furthermore if you use it now, you'll get an error since it is store_true: http://hg.mozilla.org/build/talos/file/3d1065e8e7c6/talos/PerfConfigurator.py#l371 (It shouldn't be)
Assignee | ||
Comment 12•12 years ago
|
||
Do you want me to remove --id as well?
Assignee | ||
Comment 13•12 years ago
|
||
Attachment #618836 -
Attachment is obsolete: true
Attachment #619169 -
Flags: review?(jhammel)
Comment 14•12 years ago
|
||
Comment on attachment 619169 [details] [diff] [review] Second patch attempt Nice! There's nothing I like more than seeing lots of deleted code! :)
Attachment #619169 -
Flags: review?(jhammel) → review+
Comment 15•12 years ago
|
||
Will push to try to ensure all is well, and then this should be ready to land
Whiteboard: [good first bug][mentor=BYK][lang=py] → [good first bug][mentor=BYK][lang=py][talos-checkin-needed]
Comment 16•12 years ago
|
||
I bitrotted attachment 619169 [details] [diff] [review] with my last commit. unbitrotting
Comment 17•12 years ago
|
||
pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=70bed557d894
Comment 18•12 years ago
|
||
Oops, we missed one :( Traceback (most recent call last): File "PerfConfigurator.py", line 615, in <module> sys.exit(main()) File "PerfConfigurator.py", line 600, in main configurator.writeConfigFile() File "PerfConfigurator.py", line 189, in writeConfigFile newline = self.convertLine(line) File "PerfConfigurator.py", line 121, in convertLine newline = '%s: %s\n' % (item, getattr(self, item)) AttributeError: 'PerfConfigurator' object has no attribute 'buildid'
Comment 19•12 years ago
|
||
tested locally a bit, will repush to try
Attachment #619183 -
Attachment is obsolete: true
Comment 20•12 years ago
|
||
new try push is here: https://tbpl.mozilla.org/?tree=Try&rev=49decdc3604d
Comment 21•12 years ago
|
||
Try run for 70bed557d894 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=70bed557d894 Results (out of 41 total builds): exception: 12 success: 1 failure: 28 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jhammel@mozilla.com-70bed557d894
Comment 22•12 years ago
|
||
Try run for 49decdc3604d is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=49decdc3604d Results (out of 83 total builds): exception: 1 success: 79 failure: 3 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jhammel@mozilla.com-49decdc3604d
Reporter | ||
Comment 23•12 years ago
|
||
all these exceptions/failures passed fine on a retrigger. I assume we are ready to push, but I will let :jhammel indicate that.
Comment 24•12 years ago
|
||
Looks good to me!
Comment 25•12 years ago
|
||
pushed: http://hg.mozilla.org/build/talos/rev/c702ff8892be Thanks, James!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Whiteboard: [good first bug][mentor=BYK][lang=py][talos-checkin-needed] → [good first bug][mentor=BYK][lang=py]
You need to log in
before you can comment on or make changes to this bug.
Description
•