Closed Bug 747224 Opened 8 years ago Closed 8 years ago

[layout view] handle the key events correctly

Categories

(DevTools :: Inspector, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 15

People

(Reporter: paul, Unassigned)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file, 1 obsolete file)

No description provided.
Summary: [layout view] If the inspector is closed when the layout view is focused, the inspector keyboard shortcurts don't work anymore → [layout view] If the layout view is closed when it is focused, the inspector keyboard shortcurts don't work anymore
Attached patch patch v1 (obsolete) — Splinter Review
Comment on attachment 622725 [details] [diff] [review]
patch v1

The goal of this patch is to forward the key events to the inspector.
Attachment #622725 - Flags: review?(dcamp)
Comment on attachment 622725 [details] [diff] [review]
patch v1

Review of attachment 622725 [details] [diff] [review]:
-----------------------------------------------------------------

Should the inspector just be attaching event handlers to the sidebar that handle bubbling events?
(In reply to Dave Camp (:dcamp) from comment #3)
> Comment on attachment 622725 [details] [diff] [review]
> patch v1
> 
> Review of attachment 622725 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Should the inspector just be attaching event handlers to the sidebar that
> handle bubbling events?

That would be the logic way to do it. I'll do that.
Attachment #622725 - Flags: review?(dcamp)
Actually, the more I think about it, the less I think we should support the arrow keys in the layout view.
Summary: [layout view] If the layout view is closed when it is focused, the inspector keyboard shortcurts don't work anymore → [layout view] [layout view] handle the key events correctly
Summary: [layout view] [layout view] handle the key events correctly → [layout view] handle the key events correctly
Attached patch patch v1.1Splinter Review
Attachment #622725 - Attachment is obsolete: true
Comment on attachment 623632 [details] [diff] [review]
patch v1.1

In this patch I just avoid any scroll operations in the iframe. I preventDefault() the key events. I didn't find any better way to do. Preventing the scroll events doesn't work. Any idea of how I can improve that?

The space key let the user toggle the view (when focused). Bug 747222 will introduce a more generic key shortcut.
Comment on attachment 623632 [details] [diff] [review]
patch v1.1

and I'm fixing a type (focusring).
Attachment #623632 - Flags: review?(dcamp)
s/type/typo :)
Attachment #623632 - Flags: review?(dcamp) → review+
https://hg.mozilla.org/mozilla-central/rev/d2e8c2ee67ae
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.