Closed
Bug 747224
Opened 13 years ago
Closed 13 years ago
[layout view] handle the key events correctly
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 15
People
(Reporter: paul, Unassigned)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(1 file, 1 obsolete file)
|
3.86 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Updated•13 years ago
|
Summary: [layout view] If the inspector is closed when the layout view is focused, the inspector keyboard shortcurts don't work anymore → [layout view] If the layout view is closed when it is focused, the inspector keyboard shortcurts don't work anymore
|
|
Reporter | |
Comment 1•13 years ago
|
||
|
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 622725 [details] [diff] [review] patch v1 The goal of this patch is to forward the key events to the inspector.
Attachment #622725 -
Flags: review?(dcamp)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 622725 [details] [diff] [review] patch v1 Review of attachment 622725 [details] [diff] [review]: ----------------------------------------------------------------- Should the inspector just be attaching event handlers to the sidebar that handle bubbling events?
|
|
Reporter | |
Comment 4•13 years ago
|
||
(In reply to Dave Camp (:dcamp) from comment #3) > Comment on attachment 622725 [details] [diff] [review] > patch v1 > > Review of attachment 622725 [details] [diff] [review]: > ----------------------------------------------------------------- > > Should the inspector just be attaching event handlers to the sidebar that > handle bubbling events? That would be the logic way to do it. I'll do that.
|
|
Reporter | |
Updated•13 years ago
|
Attachment #622725 -
Flags: review?(dcamp)
|
|
Reporter | |
Comment 5•13 years ago
|
||
Actually, the more I think about it, the less I think we should support the arrow keys in the layout view.
|
|
Reporter | |
Updated•13 years ago
|
Summary: [layout view] If the layout view is closed when it is focused, the inspector keyboard shortcurts don't work anymore → [layout view] [layout view] handle the key events correctly
|
|
Reporter | |
Updated•13 years ago
|
Summary: [layout view] [layout view] handle the key events correctly → [layout view] handle the key events correctly
|
|
Reporter | |
Comment 6•13 years ago
|
||
|
|
Reporter | |
Updated•13 years ago
|
Attachment #622725 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 7•13 years ago
|
||
Comment on attachment 623632 [details] [diff] [review] patch v1.1 In this patch I just avoid any scroll operations in the iframe. I preventDefault() the key events. I didn't find any better way to do. Preventing the scroll events doesn't work. Any idea of how I can improve that? The space key let the user toggle the view (when focused). Bug 747222 will introduce a more generic key shortcut.
|
|
Reporter | |
Comment 8•13 years ago
|
||
Comment on attachment 623632 [details] [diff] [review] patch v1.1 and I'm fixing a type (focusring).
Attachment #623632 -
Flags: review?(dcamp)
|
|
||
Updated•13 years ago
|
Attachment #623632 -
Flags: review?(dcamp) → review+
|
|
Reporter | |
Comment 10•13 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d2e8c2ee67ae
Whiteboard: [fixed-in-fx-team]
|
||
Comment 11•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d2e8c2ee67ae
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•