Last Comment Bug 747243 - jsgc.h(1386) : warning C4273: 'js::PrepareForFullGC' : inconsistent dll linkage
: jsgc.h(1386) : warning C4273: 'js::PrepareForFullGC' : inconsistent dll linkage
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla15
Assigned To: Ryan VanderMeulen [:RyanVM]
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks: 716142
  Show dependency treegraph
 
Reported: 2012-04-19 16:30 PDT by Ryan VanderMeulen [:RyanVM]
Modified: 2012-04-25 07:32 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (682 bytes, patch)
2012-04-19 16:33 PDT, Ryan VanderMeulen [:RyanVM]
wmccloskey: review+
Details | Diff | Splinter Review

Description Ryan VanderMeulen [:RyanVM] 2012-04-19 16:30:38 PDT
Big source of Windows warning spam.

c:\mozbuild\mozilla-central\objdir-fx-vc10\dist\include\jsgc.h(1386) : warning C4273: 'js::PrepareForFullGC' : inconsistent dll linkage
        c:\mozbuild\mozilla-central\objdir-fx-vc10\dist\include\jsfriendapi.h(651) : see previous definition of 'PrepareForFullGC'

I'm assuming that changing jsgc.h to JS_FRIEND_API(void) to match jsfriendapi.h would fix this.
http://mxr.mozilla.org/mozilla-central/source/js/src/jsgc.h#1385
Comment 1 Ryan VanderMeulen [:RyanVM] 2012-04-19 16:33:00 PDT
Created attachment 616805 [details] [diff] [review]
Patch
Comment 2 Ryan VanderMeulen [:RyanVM] 2012-04-24 17:05:52 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/5cd18a14b80f

Note You need to log in before you can comment on or make changes to this bug.