Closed Bug 747243 Opened 9 years ago Closed 9 years ago

jsgc.h(1386) : warning C4273: 'js::PrepareForFullGC' : inconsistent dll linkage

Categories

(Core :: JavaScript Engine, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: ryanvm, Assigned: ryanvm)

References

Details

Attachments

(1 file)

Big source of Windows warning spam.

c:\mozbuild\mozilla-central\objdir-fx-vc10\dist\include\jsgc.h(1386) : warning C4273: 'js::PrepareForFullGC' : inconsistent dll linkage
        c:\mozbuild\mozilla-central\objdir-fx-vc10\dist\include\jsfriendapi.h(651) : see previous definition of 'PrepareForFullGC'

I'm assuming that changing jsgc.h to JS_FRIEND_API(void) to match jsfriendapi.h would fix this.
http://mxr.mozilla.org/mozilla-central/source/js/src/jsgc.h#1385
Attached patch PatchSplinter Review
Assignee: general → ryanvm
Status: NEW → ASSIGNED
Attachment #616805 - Flags: review?(wmccloskey)
Attachment #616805 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/5cd18a14b80f
Flags: in-testsuite-
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/5cd18a14b80f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.