747247 - Fix assertions about null owners

Status: RESOLVED FIXED

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Created attachment 616806 [details] [diff] [review]
Patch, v1

Since the behavior of nsDOMEventTargetHelper changed to allow weak owners indexeddb code asserts stuff that it shouldn't.

Comment 1

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

Comment on attachment 616806 [details] [diff] [review]
Patch, v1

Review of attachment 616806 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/IDBDatabase.cpp
@@ +221,5 @@
>  
>    // When the IndexedDatabaseManager needs to invalidate databases, all it has
>    // is an origin, so we call back into the manager to cancel any prompts for
>    // our owner.
> +  nsCOMPtr<nsPIDOMWindow> owner = GetOwner();

This does not need to be a strong pointer.  Please make it weak.

Comment 2

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

https://hg.mozilla.org/mozilla-central/rev/5e462ce3cb42