Closed
Bug 747247
Opened 10 years ago
Closed 10 years ago
Fix assertions about null owners
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
Details
Attachments
(1 file)
2.40 KB,
patch
|
khuey
:
review-
|
Details | Diff | Splinter Review |
Since the behavior of nsDOMEventTargetHelper changed to allow weak owners indexeddb code asserts stuff that it shouldn't.
Attachment #616806 -
Flags: review?(khuey)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Comment on attachment 616806 [details] [diff] [review] Patch, v1 Review of attachment 616806 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/indexedDB/IDBDatabase.cpp @@ +221,5 @@ > > // When the IndexedDatabaseManager needs to invalidate databases, all it has > // is an origin, so we call back into the manager to cancel any prompts for > // our owner. > + nsCOMPtr<nsPIDOMWindow> owner = GetOwner(); This does not need to be a strong pointer. Please make it weak.
Attachment #616806 -
Flags: review?(khuey) → review-
https://hg.mozilla.org/mozilla-central/rev/5e462ce3cb42
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•