Last Comment Bug 747270 - [AccessFu] UtterangeGenerator should return string lists in all generator methods
: [AccessFu] UtterangeGenerator should return string lists in all generator met...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla15
Assigned To: Eitan Isaacson [:eeejay]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-19 18:04 PDT by Eitan Isaacson [:eeejay]
Modified: 2012-04-29 14:16 PDT (History)
3 users (show)
ryanvm: in‑testsuite?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
UtterangeGenerator should return string lists in all generator methods. (1.69 KB, patch)
2012-04-19 18:06 PDT, Eitan Isaacson [:eeejay]
dbolter: review+
Details | Diff | Splinter Review

Description Eitan Isaacson [:eeejay] 2012-04-19 18:04:21 PDT
Just for consistency, if not anything else...
Comment 1 Eitan Isaacson [:eeejay] 2012-04-19 18:06:49 PDT
Created attachment 616829 [details] [diff] [review]
UtterangeGenerator should return string lists in all generator methods.
Comment 2 David Bolter [:davidb] ***PTO until 29th*** 2012-04-20 09:42:45 PDT
Comment on attachment 616829 [details] [diff] [review]
UtterangeGenerator should return string lists in all generator methods.

Review of attachment 616829 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.

Nit: Utteran[g/c]eGenerator
Comment 3 alexander :surkov 2012-04-22 19:49:53 PDT
(In reply to Eitan Isaacson [:eeejay] from comment #0)
> Just for consistency, if not anything else...

until these methods are commented, it's hard to say what consistency you talk about: genForObject returns an array, getForAction returns a string.
Comment 4 Eitan Isaacson [:eeejay] 2012-04-27 10:45:17 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/717b3ea8f842
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-04-29 14:16:35 PDT
http://hg.mozilla.org/mozilla-central/rev/717b3ea8f842

Note You need to log in before you can comment on or make changes to this bug.