Last Comment Bug 747311 - autodetect android_toolchain on Android/x86
: autodetect android_toolchain on Android/x86
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86 Android
: -- normal (vote)
: mozilla15
Assigned To: Makoto Kato [:m_kato]
:
: Gregory Szorc [:gps]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-20 00:20 PDT by Makoto Kato [:m_kato]
Modified: 2012-04-27 06:49 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (2.27 KB, patch)
2012-04-20 00:20 PDT, Makoto Kato [:m_kato]
mh+mozilla: review+
Details | Diff | Splinter Review

Description Makoto Kato [:m_kato] 2012-04-20 00:20:42 PDT
Created attachment 616891 [details] [diff] [review]
fix

android/x86 target doesn't auto-detect android_toolchain...
Comment 1 Mike Hommey [:glandium] 2012-04-22 23:04:17 PDT
Comment on attachment 616891 [details] [diff] [review]
fix

Review of attachment 616891 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +401,5 @@
>          # With newer NDK, the toolchain path has changed.
>          if ! test -d "$android_toolchain" ; then
> +            case "$target_cpu" in
> +            arm)
> +                target_name=arm-$kernel_name-androideabi-4.4.3

While at it, please fix this by replacing $kernel_name with linux. $kernel_name is not valid for the target name except when building on linux.
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2012-04-27 06:49:23 PDT
https://hg.mozilla.org/mozilla-central/rev/8eaab92b3220

Note You need to log in before you can comment on or make changes to this bug.