Closed Bug 747311 Opened 8 years ago Closed 8 years ago

autodetect android_toolchain on Android/x86

Categories

(Firefox Build System :: General, defect)

x86
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla15

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

Attached patch fixSplinter Review
android/x86 target doesn't auto-detect android_toolchain...
Attachment #616891 - Flags: review?(mh+mozilla)
OS: Windows Vista → Android
Comment on attachment 616891 [details] [diff] [review]
fix

Review of attachment 616891 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +401,5 @@
>          # With newer NDK, the toolchain path has changed.
>          if ! test -d "$android_toolchain" ; then
> +            case "$target_cpu" in
> +            arm)
> +                target_name=arm-$kernel_name-androideabi-4.4.3

While at it, please fix this by replacing $kernel_name with linux. $kernel_name is not valid for the target name except when building on linux.
Attachment #616891 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/8eaab92b3220
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla15
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.