autodetect android_toolchain on Android/x86

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla15
x86
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 616891 [details] [diff] [review]
fix

android/x86 target doesn't auto-detect android_toolchain...
Attachment #616891 - Flags: review?(mh+mozilla)
(Assignee)

Updated

5 years ago
OS: Windows Vista → Android
Comment on attachment 616891 [details] [diff] [review]
fix

Review of attachment 616891 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +401,5 @@
>          # With newer NDK, the toolchain path has changed.
>          if ! test -d "$android_toolchain" ; then
> +            case "$target_cpu" in
> +            arm)
> +                target_name=arm-$kernel_name-androideabi-4.4.3

While at it, please fix this by replacing $kernel_name with linux. $kernel_name is not valid for the target name except when building on linux.
Attachment #616891 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8eaab92b3220
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/8eaab92b3220
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.