Closed
Bug 747465
Opened 13 years ago
Closed 13 years ago
clobber blows away mozharness localconfig.json
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Release Engineering
Applications: MozharnessCore
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mozilla, Assigned: mozilla)
Details
(Whiteboard: [mozharness])
Attachments
(1 file)
|
2.25 KB,
patch
|
rail
:
review+
mozilla
:
checked-in+
|
Details | Diff | Splinter Review |
I cleverly updated dump_config() to write localconfig.json to abs_upload_dir, which is under the work dir.
The first step in many scripts is clobber, which blows away your work dir. That means the upload dir and newly-created localconfig.json are blown away.
I need to revert to my previous logic: write localconfig.json to the log dir, and copy_to_upload_dir() along with the logs at the end of the script.
| Assignee | ||
Comment 1•13 years ago
|
||
Attachment #617045 -
Flags: review?(rail)
Comment 2•13 years ago
|
||
Comment on attachment 617045 [details] [diff] [review]
dump_config to abs_log_dir, copy to upload dir
lgtm
Attachment #617045 -
Flags: review?(rail) → review+
| Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 617045 [details] [diff] [review]
dump_config to abs_log_dir, copy to upload dir
http://hg.mozilla.org/build/mozharness/rev/a2bf4cecc553
Attachment #617045 -
Flags: checked-in+
| Assignee | ||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
Updated•11 years ago
|
Component: General Automation → Mozharness
You need to log in
before you can comment on or make changes to this bug.
Description
•