Last Comment Bug 747517 - Apply font element / text decoration quirk in all modes
: Apply font element / text decoration quirk in all modes
Status: RESOLVED WONTFIX
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
:
Mentors:
Depends on:
Blocks: quirks-mode-spec
  Show dependency treegraph
 
Reported: 2012-04-20 13:37 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-11-15 23:01 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (3.40 KB, patch)
2012-06-09 07:48 PDT, :Ms2ger (⌚ UTC+1/+2)
dbaron: review-
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-04-20 13:37:18 PDT
The current check in nsHTMLFontElement was added in <https://hg.mozilla.org/mozilla-central/rev/88d8bfd7ef64>; AIUI, to preserve behaviour in bug 403524.

Looking at

data:text/html;charset=utf-8,<!doctype html><u>a<font color=red>foo</font>b</u>
data:text/html;charset=utf-8,<u>a<font color=red>foo</font>b</u>

Chrome underlines foo in red in all modes; we and Opera only do it in quirks mode, and IE never does it. Opera would be happy to make it apply in all modes as well.
Comment 1 Simon Pieters 2012-04-20 14:14:49 PDT
IE does it in its compat-view quirks mode and compat-view standards mode.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-06-09 07:48:36 PDT
Created attachment 631665 [details] [diff] [review]
Patch v1
Comment 3 David Baron :dbaron: ⌚️UTC-7 2012-06-18 13:41:43 PDT
If we're going to do this, shouldn't it go in a specification somewhere?  (Perhaps the Rendering section of HTML5?)
Comment 4 Simon Pieters 2012-06-19 03:33:27 PDT
It's currently specified here: http://simon.html5.org/specs/quirks-mode#the-font-element-text-decoration-color-quirk
Comment 5 David Baron :dbaron: ⌚️UTC-7 2012-08-03 14:59:19 PDT
I'm actually somewhat inclined to keep this quirks mode only, though I don't feel especially strongly.

I think the rationale for reducing the number of quirks is that it reduces the number of strange exceptions that authors have to learn and that browsers have to implement.  In this case, however, we're already dealing with a strange exception to a very general rule (a single-element exception to an all-elements rule), and the question is whether that exception applies in a more restricted or less restricted set of cases.  I'd rather keep it more restricted so that at least standards mode has fewer strange exceptions, even though the decision doesn't affect (either way) the number of strange exceptions in the Web platform as a whole.
Comment 6 Simon Pieters 2012-08-12 03:09:50 PDT
The font element is non-conforming so authors using valid HTML don't need to learn about this exception.
Comment 7 David Baron :dbaron: ⌚️UTC-7 2012-11-15 23:00:54 PST
That doesn't mean it isn't out there in existing content that authors have to maintain.

My inclination is to keep this as-is, though I'd also be open to consider removing the quirk entirely (particularly if there were evidence from someone other than IE non-compat-mode).

Note You need to log in before you can comment on or make changes to this bug.