747533 - Social sharing library: Page width issue on display of sharing services

Status: VERIFIED FIXED

(mozilla.org Graveyard :: Webdev, task)

Description

[Chris More [:cmore]]

Page expands horizontally when social services are displayed. Shown in this comment:

https://bugzilla.mozilla.org/show_bug.cgi?id=745958#c2

Comment 1

[Owen Coutts [:tallOwen]]

This was a mistake on the way I originally inserted the plugin into the page. Should be fixed now.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

I can actually still reproduce on my MacBook Pro, with nightly, on 1440x900 resolution, here: http://people.mozilla.org/~ocoutts/collusion/

Reopening, sorry!

Comment 3

[Chris More [:cmore]]

Owen: Did you refresh the people page?

Comment 4

[Owen Coutts [:tallOwen]]

This is an issue with the way the CSS was done on the collusion page. Perhaps somebody with more time could shoehorn it in, but I don't think that changes could be made to the plugin code.

Comment 5

[Chris More [:cmore]]

Stephen: I'm pretty sure that the width issue on the page was because the CSS may have got messed up when I made a static copy of the collusion page and manually adjusted the CSS to get it to work. Check out the sample page below and see if you see the problem:

http://icaaq.com/sandbox/mozilla/SocialShare/multiple.html

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

I don't see the problem on http://icaaq.com/sandbox/mozilla/SocialShare/multiple.html; guessing that since Owen's gone, the ability to test it on http://people.mozilla.org/~ocoutts/collusion/ is too?  It'd just be nice to see another "fixed" datapoint, if possible :-)

Comment 7

[Chris More [:cmore]]

(In reply to Stephen Donner [:stephend] from comment #6)
> I don't see the problem on
> http://icaaq.com/sandbox/mozilla/SocialShare/multiple.html; guessing that
> since Owen's gone, the ability to test it on
> http://people.mozilla.org/~ocoutts/collusion/ is too?  It'd just be nice to
> see another "fixed" datapoint, if possible :-)

Sure. I ping'd pmac on the main QA bug to have it installed on another place for verification. Is it possible for the QA team to install it on any site they have access to even if it is not a Mozilla theme property?

Comment 8

[Chris More [:cmore]]

pmac: Can you install the library on a static version of a Mozilla website so that QA can verify this bug is "invalid"?

Comment 9

[Paul [:pmac] McLanahan]

Small CSS change seems to have fixed it. Test at the URL below.

http://people.mozilla.org/~pmclanahan/collusion/

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks, pmac!