747598 - ReadPixels supports all sorts of formats and types we should not support per spec

Status: RESOLVED INVALID

(Core :: Graphics: CanvasWebGL, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Per spec, we should only support format=RGBA, type=UNSIGNED_BYTE.

Please don't fix this until I'm done with bug 745897!  I'd prefer to avoid the merge pain.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Have you tested this? It should probably be earlier in the function, but we should be checking this here:
http://mxr.mozilla.org/mozilla-central/source/content/canvas/src/WebGLContextGL.cpp#3452

Comment 2

[Boris Zbarsky [:bzbarsky]]

No, I hadn't tested; the bug was based on (somewhat cursory) code inspection.

I agree that the code you link to means the bug as filed is invalid.  I still think the function is confusing and we could remove a bunch of code in it if we did the check earlier; please feel free to reopen and morph if that's desired!

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

This test already covers it well (see "check disallowed formats"):

https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/reading/read-pixels-test.html

We are passing it.