Closed Bug 747642 Opened 12 years ago Closed 12 years ago

cleanup in AndroidJNI

Categories

(Core Graveyard :: Widget: Android, defect)

x86
macOS
defect
Not set
normal

Tracking

(firefox14 fixed)

RESOLVED FIXED
mozilla15
Tracking Status
firefox14 --- fixed

People

(Reporter: blassey, Assigned: blassey)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
mwu, any reason you did it this way in the first place?
Attachment #617226 - Flags: review?(mwu)
Comment on attachment 617226 [details] [diff] [review]
patch

You'll have to ask vlad since I didn't write this.
Attachment #617226 - Attachment is patch: true
Attachment #617226 - Flags: review?(mwu) → review+
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/55c5e6d0e9ec
Assignee: nobody → blassey.bugs
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 617226 [details] [diff] [review]
patch

requesting approval to avoid "merge conflicts" going forward. They won't be merge conflicts in the traditional sense, instead the patches will apply and then the build will crash mysteriously on startup.

This is a very safe change.

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: None, this is code clean up
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch: none
Attachment #617226 - Flags: approval-mozilla-aurora?
Comment on attachment 617226 [details] [diff] [review]
patch

[Triage Comment]
Mobile only, approving for Aurora 14.
Attachment #617226 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: