747642 - cleanup in AndroidJNI

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

mwu, any reason you did it this way in the first place?

Comment 1

[Michael Wu [:mwu]]

Comment on attachment 617226 [details] [diff] [review]
patch

You'll have to ask vlad since I didn't write this.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Follow-up for Android XUL bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0c4bc2aba54

Comment 3

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/55c5e6d0e9ec

Comment 4

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/1e2e0e7972a5 (empty)
https://hg.mozilla.org/mozilla-central/rev/f0c4bc2aba54

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 617226 [details] [diff] [review]
patch

requesting approval to avoid "merge conflicts" going forward. They won't be merge conflicts in the traditional sense, instead the patches will apply and then the build will crash mysteriously on startup.

This is a very safe change.

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: None, this is code clean up
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch: none

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 617226 [details] [diff] [review]
patch

[Triage Comment]
Mobile only, approving for Aurora 14.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/317262a2c3b7