cleanup in AndroidJNI

RESOLVED FIXED in Firefox 14

Status

()

Core
Widget: Android
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: blassey, Assigned: blassey)

Tracking

unspecified
mozilla15
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox14 fixed)

Details

Attachments

(1 attachment)

Created attachment 617226 [details] [diff] [review]
patch

mwu, any reason you did it this way in the first place?
Attachment #617226 - Flags: review?(mwu)

Comment 1

5 years ago
Comment on attachment 617226 [details] [diff] [review]
patch

You'll have to ask vlad since I didn't write this.
Attachment #617226 - Attachment is patch: true
Attachment #617226 - Flags: review?(mwu) → review+
Follow-up for Android XUL bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0c4bc2aba54
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/55c5e6d0e9ec
Assignee: nobody → blassey.bugs
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/mozilla-central/rev/1e2e0e7972a5 (empty)
https://hg.mozilla.org/mozilla-central/rev/f0c4bc2aba54
Comment on attachment 617226 [details] [diff] [review]
patch

requesting approval to avoid "merge conflicts" going forward. They won't be merge conflicts in the traditional sense, instead the patches will apply and then the build will crash mysteriously on startup.

This is a very safe change.

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: None, this is code clean up
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch: none
Attachment #617226 - Flags: approval-mozilla-aurora?

Comment 6

5 years ago
Comment on attachment 617226 [details] [diff] [review]
patch

[Triage Comment]
Mobile only, approving for Aurora 14.
Attachment #617226 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/317262a2c3b7
status-firefox14: --- → fixed
You need to log in before you can comment on or make changes to this bug.