Closed
Bug 747642
Opened 12 years ago
Closed 12 years ago
cleanup in AndroidJNI
Categories
(Core Graveyard :: Widget: Android, defect)
Tracking
(firefox14 fixed)
RESOLVED
FIXED
mozilla15
Tracking | Status | |
---|---|---|
firefox14 | --- | fixed |
People
(Reporter: blassey, Assigned: blassey)
Details
Attachments
(1 file)
4.47 KB,
patch
|
mwu
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
mwu, any reason you did it this way in the first place?
Attachment #617226 -
Flags: review?(mwu)
Comment 1•12 years ago
|
||
Comment on attachment 617226 [details] [diff] [review] patch You'll have to ask vlad since I didn't write this.
Attachment #617226 -
Attachment is patch: true
Attachment #617226 -
Flags: review?(mwu) → review+
Comment 2•12 years ago
|
||
Follow-up for Android XUL bustage. https://hg.mozilla.org/integration/mozilla-inbound/rev/f0c4bc2aba54
Updated•12 years ago
|
Target Milestone: --- → mozilla15
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/55c5e6d0e9ec
Assignee: nobody → blassey.bugs
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1e2e0e7972a5 (empty) https://hg.mozilla.org/mozilla-central/rev/f0c4bc2aba54
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 617226 [details] [diff] [review] patch requesting approval to avoid "merge conflicts" going forward. They won't be merge conflicts in the traditional sense, instead the patches will apply and then the build will crash mysteriously on startup. This is a very safe change. [Approval Request Comment] Regression caused by (bug #): User impact if declined: None, this is code clean up Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): String changes made by this patch: none
Attachment #617226 -
Flags: approval-mozilla-aurora?
Comment 6•12 years ago
|
||
Comment on attachment 617226 [details] [diff] [review] patch [Triage Comment] Mobile only, approving for Aurora 14.
Attachment #617226 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/317262a2c3b7
status-firefox14:
--- → fixed
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•