Last Comment Bug 747675 - Investigate if max forgetSkippable times could be decreased
: Investigate if max forgetSkippable times could be decreased
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: 12 Branch
: x86_64 Linux
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug] (vacation Aug 25-28)
Depends on: 751561
Blocks: 698919
  Show dependency treegraph
Reported: 2012-04-21 13:11 PDT by Olli Pettay [:smaug] (vacation Aug 25-28)
Modified: 2012-05-20 14:23 PDT (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (1.45 KB, patch)
2012-04-21 13:11 PDT, Olli Pettay [:smaug] (vacation Aug 25-28)
continuation: review+
Details | Diff | Splinter Review

Description Olli Pettay [:smaug] (vacation Aug 25-28) 2012-04-21 13:11:29 PDT
Created attachment 617253 [details] [diff] [review]

I'd like to try something like this. Basically split the slowest
forget skippable to two parts.
Would have to look at telemetry data to see how this affects to
max forgetSkippable times, and whether CC times are affected too.
Comment 1 Olli Pettay [:smaug] (vacation Aug 25-28) 2012-04-21 14:24:04 PDT
Comment 2 Andrew McCreight [:mccr8] 2012-04-22 05:30:06 PDT
Comment on attachment 617253 [details] [diff] [review]

Looks reasonable.

Are the max forget skippable times in telemetry actually bad?  Have you tried profiling to see how much each of these things you are splitting up takes?
Comment 3 Olli Pettay [:smaug] (vacation Aug 25-28) 2012-04-22 05:36:30 PDT
UnmarkGrayJSListenersInCCGenerationDocuments and xpc_UnmarkSkippableJSHolders tend
both to be somewhat slow, at least when I have lots of tabs open.
But I'll do some profiling again (haven't done any for few weeks).
Comment 4 Olli Pettay [:smaug] (vacation Aug 25-28) 2012-04-25 12:21:21 PDT
Comment 5 Olli Pettay [:smaug] (vacation Aug 25-28) 2012-04-27 03:39:04 PDT
Backed out in order to investigate Bug 749461
Comment 6 Olli Pettay [:smaug] (vacation Aug 25-28) 2012-04-28 03:54:22 PDT
Based on the initial telemetry data, the patch doesn't affect too much to the
already low median times, but helps significantly with the worst 5%, so mean time decreases quite nicely.
Comment 7 Olli Pettay [:smaug] (vacation Aug 25-28) 2012-04-29 03:44:12 PDT

Note You need to log in before you can comment on or make changes to this bug.