Closed Bug 747675 Opened 8 years ago Closed 8 years ago

Investigate if max forgetSkippable times could be decreased

Categories

(Core :: XPCOM, defect)

12 Branch
x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Snappy])

Attachments

(1 file)

Attached patch patchSplinter Review
I'd like to try something like this. Basically split the slowest
forget skippable to two parts.
Would have to look at telemetry data to see how this affects to
max forgetSkippable times, and whether CC times are affected too.
Attachment #617253 - Flags: review?(continuation)
Comment on attachment 617253 [details] [diff] [review]
patch

Looks reasonable.

Are the max forget skippable times in telemetry actually bad?  Have you tried profiling to see how much each of these things you are splitting up takes?
Attachment #617253 - Flags: review?(continuation) → review+
UnmarkGrayJSListenersInCCGenerationDocuments and xpc_UnmarkSkippableJSHolders tend
both to be somewhat slow, at least when I have lots of tabs open.
But I'll do some profiling again (haven't done any for few weeks).
https://hg.mozilla.org/mozilla-central/rev/4b6514ffcf16
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Backed out in order to investigate Bug 749461
https://hg.mozilla.org/mozilla-central/rev/0aa393eef856
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Based on the initial telemetry data, the patch doesn't affect too much to the
already low median times, but helps significantly with the worst 5%, so mean time decreases quite nicely.
Whiteboard: [Snappy]
Blocks: 698919
https://hg.mozilla.org/mozilla-central/rev/f622f1ccef2b
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Depends on: 751561
No longer blocks: 698919
Blocks: 698919
No longer depends on: 751561
You need to log in before you can comment on or make changes to this bug.