Investigate if max forgetSkippable times could be decreased

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

(Blocks: 1 bug)

12 Branch
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Snappy])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 617253 [details] [diff] [review]
patch

I'd like to try something like this. Basically split the slowest
forget skippable to two parts.
Would have to look at telemetry data to see how this affects to
max forgetSkippable times, and whether CC times are affected too.
Attachment #617253 - Flags: review?(continuation)
(Assignee)

Comment 1

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=d1e73c1ce6d6
Comment on attachment 617253 [details] [diff] [review]
patch

Looks reasonable.

Are the max forget skippable times in telemetry actually bad?  Have you tried profiling to see how much each of these things you are splitting up takes?
Attachment #617253 - Flags: review?(continuation) → review+
(Assignee)

Comment 3

5 years ago
UnmarkGrayJSListenersInCCGenerationDocuments and xpc_UnmarkSkippableJSHolders tend
both to be somewhat slow, at least when I have lots of tabs open.
But I'll do some profiling again (haven't done any for few weeks).
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/4b6514ffcf16
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

5 years ago
Backed out in order to investigate Bug 749461
https://hg.mozilla.org/mozilla-central/rev/0aa393eef856
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

5 years ago
Based on the initial telemetry data, the patch doesn't affect too much to the
already low median times, but helps significantly with the worst 5%, so mean time decreases quite nicely.
Whiteboard: [Snappy]
Blocks: 698919
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f622f1ccef2b
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Depends on: 751561
No longer blocks: 698919
Blocks: 698919
No longer depends on: 751561
Depends on: 751561
You need to log in before you can comment on or make changes to this bug.