Closed
Bug 747675
Opened 12 years ago
Closed 12 years ago
Investigate if max forgetSkippable times could be decreased
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Snappy])
Attachments
(1 file)
1.45 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
I'd like to try something like this. Basically split the slowest forget skippable to two parts. Would have to look at telemetry data to see how this affects to max forgetSkippable times, and whether CC times are affected too.
Attachment #617253 -
Flags: review?(continuation)
Assignee | ||
Comment 1•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=d1e73c1ce6d6
Comment 2•12 years ago
|
||
Comment on attachment 617253 [details] [diff] [review] patch Looks reasonable. Are the max forget skippable times in telemetry actually bad? Have you tried profiling to see how much each of these things you are splitting up takes?
Attachment #617253 -
Flags: review?(continuation) → review+
Assignee | ||
Comment 3•12 years ago
|
||
UnmarkGrayJSListenersInCCGenerationDocuments and xpc_UnmarkSkippableJSHolders tend both to be somewhat slow, at least when I have lots of tabs open. But I'll do some profiling again (haven't done any for few weeks).
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4b6514ffcf16
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•12 years ago
|
||
Backed out in order to investigate Bug 749461 https://hg.mozilla.org/mozilla-central/rev/0aa393eef856
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•12 years ago
|
||
Based on the initial telemetry data, the patch doesn't affect too much to the already low median times, but helps significantly with the worst 5%, so mean time decreases quite nicely.
Updated•12 years ago
|
Whiteboard: [Snappy]
Assignee | ||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f622f1ccef2b
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•