Last Comment Bug 747742 - Arrowpanel isn't at the right place with the new identity block (Windows, Linux)
: Arrowpanel isn't at the right place with the new identity block (Windows, Linux)
Status: RESOLVED FIXED
: regression
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 14
Assigned To: Dão Gottwald [:dao]
:
: Dão Gottwald [:dao]
Mentors:
Depends on:
Blocks: 742419 747977
  Show dependency treegraph
 
Reported: 2012-04-22 06:35 PDT by Guillaume C. [:ge3k0s]
Modified: 2012-04-24 11:35 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch for Windows and Linux (4.71 KB, patch)
2012-04-23 10:16 PDT, Dão Gottwald [:dao]
jaws: review+
Details | Diff | Splinter Review

Description Guillaume C. [:ge3k0s] 2012-04-22 06:35:56 PDT
With the new identity block landed the arrow of the identity panel appears a bit on the left of the generic icon. It should be directly under the icon.
Comment 1 Dão Gottwald [:dao] 2012-04-23 10:16:05 PDT
Created attachment 617517 [details] [diff] [review]
patch for Windows and Linux
Comment 2 Siddhartha Dugar [:sdrocking] 2012-04-23 10:27:01 PDT
The doorhanger also needs to be shifted upwards by a few pixels for security reasons. Otherwise a webpage can show a similar image which the user may confuse with the doorhanger. This is more visible in small icon mode. The doorhanger should be attached to the lock/globe icon (like in Google Chrome).
Comment 3 Dão Gottwald [:dao] 2012-04-23 12:14:47 PDT
http://hg.mozilla.org/mozilla-central/rev/09750e764b6a
Comment 4 Guillaume C. [:ge3k0s] 2012-04-24 11:35:08 PDT
With the conditional button not visible (default state) and the https padlock the arrow is still 1 px too on the left.

Note You need to log in before you can comment on or make changes to this bug.