747765 - Cannot add/remove Print icon in Composer toolbar

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Peter Madsen]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko/20120312 Firefox/11.0 SeaMonkey/2.8
Build ID: 20120312220748

Steps to reproduce:

I disable the Print icon in Edit -> Preferences -> Composer -> Toolbars


Actual results:

I open the Composer - the Print icon is still visible.


Expected results:

The Print icon should not be visible.

Comment 1

[Phoenix]

Confirming issue on trunk
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120421 Firefox/14.0a1 SeaMonkey/2.11a1

Comment 2

[Philip Chee]

IanN, you changed the ID of the print button didn't you?

Comment 3

[Ian Neal]

Attachment: Sticking plaster fix [Checked in: Comment 8]

This patch:
* Checks for one format of the button id and if it doesn't exist then tries a second form

Comment 4

[[e-mail]]

Comment on attachment 617350 [details] [diff] [review]
Sticking plaster fix [Checked in: Comment 8]

I can't wait for customisable toolbars ;-)

Comment 5

[Ian Neal]

Comment on attachment 617350 [details] [diff] [review]
Sticking plaster fix [Checked in: Comment 8]

[Approval Request Comment]
Regression caused by (bug #): 676991
User impact if declined: print button cannot be hidden
Testing completed (on m-c, etc.): Yes
Risk to taking this patch (and alternatives if risky): Very low risk
String changes made by this patch: None

Comment 6

[Philip Chee]

> +    var button = document.getElementById(id + "Button");
> +    if (!button)
> +      button = document.getElementById(id + "-button");
Hmm can't we do it in a more compact way?

var button = document.getElementById(id + "Button") ||
             document.getElementById(id + "-button");

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 617350 [details] [diff] [review]
Sticking plaster fix [Checked in: Comment 8]

Since the button is still *functional* I'm not going to take in 2.9-beta for the mere fact that we cannot hide it.

Beta is already in release repo, and while I could still technically take final build with a beta-approved patch tonight, I'm not taking this.

Comment 8

[Ian Neal]

Comment on attachment 617350 [details] [diff] [review]
Sticking plaster fix [Checked in: Comment 8]

Using Ratty's suggestion:
http://hg.mozilla.org/comm-central/rev/32d4b5f03e29
http://hg.mozilla.org/releases/comm-aurora/rev/4f865952d02b