Last Comment Bug 747774 - The Windows 7 Jumplist is using the mailbiff icon, should use html-file.ico instead.
: The Windows 7 Jumplist is using the mailbiff icon, should use html-file.ico i...
Status: RESOLVED FIXED
: relnote
Product: SeaMonkey
Classification: Client Software
Component: OS Integration (show other bugs)
: Trunk
: x86 Windows 7
: -- normal (vote)
: seamonkey2.11
Assigned To: Philip Chee
:
:
Mentors:
Depends on:
Blocks: 581526
  Show dependency treegraph
 
Reported: 2012-04-22 11:13 PDT by Philip Chee
Modified: 2012-04-22 21:33 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed


Attachments
Patch v1.0 Proposed fix. (6.53 KB, patch)
2012-04-22 11:24 PDT, Philip Chee
neil: review+
Details | Diff | Splinter Review

Description Philip Chee 2012-04-22 11:13:02 PDT

    
Comment 1 Philip Chee 2012-04-22 11:24:56 PDT
Created attachment 617331 [details] [diff] [review]
Patch v1.0 Proposed fix.

While working on Bug 701432 I noticed several problems with the Windows 7
Jumplist.

> +++ b/suite/modules/WindowsJumpLists.jsm
> -        let shortcut = this._getHandlerAppItem(title, title, aResult.uri, 1);

We blindly copied this from Firefox. In firefox the second icon resource is
document.ico, In SeaMonkey, however, it's the Mailbiff icon (newmail.ico).

> +        let shortcut = this._getHandlerAppItem(title, title, aResult.uri, 2);

This patch adds a third icon resource to SeaMonkey.exe using html-file.ico
which is the closest I can find to the Firefox document.ico and switches
the WindowsJumpLists.jsm to use that instead.

Also a drive by patch to remove bits of splash.rc that were there to support
MOZ_STATIC_BUILD which was removed in Bug 684155 (Remove MOZ_STATIC_BUILD).
Comment 2 Jens Hatlak (:InvisibleSmiley) 2012-04-22 11:31:46 PDT
Bah, I can't believe I never (attentively) noticed this. Thanks Ratty (bug + fix)!
Comment 3 Philip Chee 2012-04-22 12:10:15 PDT
Comment on attachment 617331 [details] [diff] [review]
Patch v1.0 Proposed fix.

I forgot to add that you need to delete the Windows 7 icon cache and rebuild it before you can see any changes. This drove me crazy for a while wondering why my patch wasn't working, dammit :P (and explains why I was never able to devise a consistent STR to test my patch in Bug 701432).
Comment 4 neil@parkwaycc.co.uk 2012-04-22 12:31:12 PDT
Comment on attachment 617331 [details] [diff] [review]
Patch v1.0 Proposed fix.

> 	cp $(srcdir)/icons/windows/seamonkey.ico      $(DIST)/branding/seamonkey.ico
>+	cp $(srcdir)/icons/windows/html-file.ico      $(DIST)/branding/html-file.ico
> 	cp $(srcdir)/package/windows/branding.nsi     $(DIST)/branding/branding.nsi
> 	cp $(srcdir)/package/windows/wizHeader.bmp    $(DIST)/branding/wizHeader.bmp
> 	cp $(srcdir)/package/windows/wizHeaderRTL.bmp $(DIST)/branding/wizHeaderRTL.bmp
> 	cp $(srcdir)/package/windows/wizWatermark.bmp $(DIST)/branding/wizWatermark.bmp
[I wonder why this uses separate cp commands...]

>-    // We don't want source redirects for these queries.
>-    options.redirectsMode = Ci.nsINavHistoryQueryOptions.REDIRECTS_MODE_TARGET;
Is this change copied from somewhere? r=me if it is.
Comment 5 Jens Hatlak (:InvisibleSmiley) 2012-04-22 12:56:11 PDT
(In reply to Philip Chee from comment #3)
> I forgot to add that you need to delete the Windows 7 icon cache and rebuild
> it before you can see any changes.

Ah OK, then no matter what we do here, users need to take action. Setting relnote keyword.

I guess we want this fixed on branches, too? (Don't bother requesting comm-beta approval right now; we won't have another beta before the uplift.)
Comment 6 Philip Chee 2012-04-22 21:22:02 PDT
>>-    // We don't want source redirects for these queries.
>>-    options.redirectsMode = Ci.nsINavHistoryQueryOptions.REDIRECTS_MODE_TARGET;
> Is this change copied from somewhere? r=me if it is.

Urgh. Forgot to say that I kept getting this error when testing my patch:
> Error: Cannot modify properties of a WrappedNative = NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN

So I ported [Bug 737841 - Part 3: remove no more useful redirectsMode query option] to kill this error message.

> I guess we want this fixed on branches, too?
I don't think so, this is purely a cosmetic issue. security-- and stability--.
Comment 7 Philip Chee 2012-04-22 21:33:09 PDT
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/2cbb85b289f5

Commit comment:
Bug 747774 The Windows 7 Jumplist is using the mailbiff icon, should use html-file.ico instead r=Neil.
Also ports:
Bug 684155 (Remove MOZ_STATIC_BUILD)
Bug 737841 Part 3 (remove no more useful redirectsMode query option)

Note You need to log in before you can comment on or make changes to this bug.