Closed
Bug 747815
Opened 13 years ago
Closed 13 years ago
DOM bindings should enforce constness of string in params
Categories
(Core :: DOM: Core & HTML, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.77 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
Right now, we don't do that. Patch coming up.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #617369 -
Flags: review?(peterv)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 617369 [details] [diff] [review]
Use const strings for arguments in DOM bindings.
Review of attachment 617369 [details] [diff] [review]:
-----------------------------------------------------------------
Not sure what the advantage is (we usually don't do this).
Attachment #617369 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Makes it harder to write DOM method decls that look like they have an out param when they actually have an in param. With this patch, they just won't compile.
|
|
Assignee | |
Comment 4•13 years ago
|
||
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla15
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•