The default bug view has changed. See this FAQ.

DOM bindings should enforce constness of string in params

RESOLVED FIXED in mozilla15

Status

()

Core
DOM
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

(Blocks: 1 bug)

unspecified
mozilla15
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Right now, we don't do that.  Patch coming up.
Created attachment 617369 [details] [diff] [review]
Use const strings for arguments in DOM bindings.
Attachment #617369 - Flags: review?(peterv)
Comment on attachment 617369 [details] [diff] [review]
Use const strings for arguments in DOM bindings.

Review of attachment 617369 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure what the advantage is (we usually don't do this).
Attachment #617369 - Flags: review?(peterv) → review+
Makes it harder to write DOM method decls that look like they have an out param when they actually have an in param.  With this patch, they just won't compile.
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cd647942ca9
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/2cd647942ca9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.