Last Comment Bug 747815 - DOM bindings should enforce constness of string in params
: DOM bindings should enforce constness of string in params
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86 Mac OS X
: P1 normal (vote)
: mozilla15
Assigned To: Boris Zbarsky [:bz] (still a bit busy)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: ParisBindings
  Show dependency treegraph
 
Reported: 2012-04-22 20:06 PDT by Boris Zbarsky [:bz] (still a bit busy)
Modified: 2012-04-26 10:34 PDT (History)
1 user (show)
bzbarsky: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Use const strings for arguments in DOM bindings. (2.77 KB, patch)
2012-04-22 20:07 PDT, Boris Zbarsky [:bz] (still a bit busy)
peterv: review+
Details | Diff | Splinter Review

Description Boris Zbarsky [:bz] (still a bit busy) 2012-04-22 20:06:13 PDT
Right now, we don't do that.  Patch coming up.
Comment 1 Boris Zbarsky [:bz] (still a bit busy) 2012-04-22 20:07:39 PDT
Created attachment 617369 [details] [diff] [review]
Use const strings for arguments in DOM bindings.
Comment 2 Peter Van der Beken [:peterv] 2012-04-25 07:53:49 PDT
Comment on attachment 617369 [details] [diff] [review]
Use const strings for arguments in DOM bindings.

Review of attachment 617369 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure what the advantage is (we usually don't do this).
Comment 3 Boris Zbarsky [:bz] (still a bit busy) 2012-04-25 07:58:46 PDT
Makes it harder to write DOM method decls that look like they have an out param when they actually have an in param.  With this patch, they just won't compile.
Comment 4 Boris Zbarsky [:bz] (still a bit busy) 2012-04-25 21:45:21 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cd647942ca9
Comment 5 Ed Morley [:emorley] 2012-04-26 10:34:20 PDT
https://hg.mozilla.org/mozilla-central/rev/2cd647942ca9

Note You need to log in before you can comment on or make changes to this bug.