Last Comment Bug 747825 - Make WebGLContext an nsWrapperCache
: Make WebGLContext an nsWrapperCache
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Canvas: WebGL (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla15
Assigned To: Boris Zbarsky [:bz] (TPAC)
:
Mentors:
Depends on:
Blocks: 745897
  Show dependency treegraph
 
Reported: 2012-04-22 21:56 PDT by Boris Zbarsky [:bz] (TPAC)
Modified: 2012-05-05 03:39 PDT (History)
2 users (show)
bzbarsky: in‑testsuite?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Make the WebGLContext a wrapper cache. (3.10 KB, patch)
2012-04-22 21:57 PDT, Boris Zbarsky [:bz] (TPAC)
no flags Details | Diff | Splinter Review
Make the WebGLContext a wrapper cache. (3.19 KB, patch)
2012-04-22 22:24 PDT, Boris Zbarsky [:bz] (TPAC)
no flags Details | Diff | Splinter Review
Make the WebGLContext a wrapper cache. (3.18 KB, patch)
2012-04-22 22:34 PDT, Boris Zbarsky [:bz] (TPAC)
no flags Details | Diff | Splinter Review
With PreCreate hook (5.10 KB, patch)
2012-04-23 21:14 PDT, Boris Zbarsky [:bz] (TPAC)
peterv: review+
Details | Diff | Splinter Review

Description Boris Zbarsky [:bz] (TPAC) 2012-04-22 21:56:38 PDT
We'll need this for the new DOM bindings.
Comment 1 Boris Zbarsky [:bz] (TPAC) 2012-04-22 21:57:31 PDT
Created attachment 617386 [details] [diff] [review]
Make the WebGLContext a wrapper cache.
Comment 2 Boris Zbarsky [:bz] (TPAC) 2012-04-22 22:24:02 PDT
Created attachment 617391 [details] [diff] [review]
Make the WebGLContext a wrapper cache.
Comment 3 Boris Zbarsky [:bz] (TPAC) 2012-04-22 22:34:11 PDT
Created attachment 617394 [details] [diff] [review]
Make the WebGLContext a wrapper cache.
Comment 4 Peter Van der Beken [:peterv] 2012-04-23 10:00:37 PDT
Comment on attachment 617394 [details] [diff] [review]
Make the WebGLContext a wrapper cache.

Review of attachment 617394 [details] [diff] [review]:
-----------------------------------------------------------------

I think you also need to add a PreCreate hook :-/. Otherwise we might create a WN in a scope other than the parent object's scope, which is then the only real wrapper for that WebGLContext.
Comment 5 Boris Zbarsky [:bz] (TPAC) 2012-04-23 10:14:45 PDT
Aha!  Yes, makes sense.  That's why you're tagged as the reviewer!  ;)
Comment 6 Boris Zbarsky [:bz] (TPAC) 2012-04-23 21:14:54 PDT
Created attachment 617772 [details] [diff] [review]
With PreCreate hook
Comment 7 Boris Zbarsky [:bz] (TPAC) 2012-05-04 09:42:06 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9369cb6d43e
Comment 8 :Ms2ger (⌚ UTC+1/+2) 2012-05-05 03:39:15 PDT
https://hg.mozilla.org/mozilla-central/rev/c9369cb6d43e

Note You need to log in before you can comment on or make changes to this bug.