Closed
Bug 747825
Opened 13 years ago
Closed 13 years ago
Make WebGLContext an nsWrapperCache
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file, 3 obsolete files)
|
5.10 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
We'll need this for the new DOM bindings.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #617386 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #617391 -
Flags: review?(peterv)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #617386 -
Attachment is obsolete: true
Attachment #617386 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #617394 -
Flags: review?(peterv)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #617391 -
Attachment is obsolete: true
Attachment #617391 -
Flags: review?(peterv)
|
||
Comment 4•13 years ago
|
||
Comment on attachment 617394 [details] [diff] [review]
Make the WebGLContext a wrapper cache.
Review of attachment 617394 [details] [diff] [review]:
-----------------------------------------------------------------
I think you also need to add a PreCreate hook :-/. Otherwise we might create a WN in a scope other than the parent object's scope, which is then the only real wrapper for that WebGLContext.
|
|
Assignee | |
Comment 5•13 years ago
|
||
Aha! Yes, makes sense. That's why you're tagged as the reviewer! ;)
|
|
Assignee | |
Comment 6•13 years ago
|
||
Attachment #617772 -
Flags: review?(peterv)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #617394 -
Attachment is obsolete: true
Attachment #617394 -
Flags: review?(peterv)
|
|
||
Updated•13 years ago
|
Attachment #617772 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 7•13 years ago
|
||
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla15
|
||
Comment 8•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•