Make WebGLContext an nsWrapperCache

RESOLVED FIXED in mozilla15

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

unspecified
mozilla15
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

We'll need this for the new DOM bindings.
Blocks: 745897
Whiteboard: [need review]
Created attachment 617386 [details] [diff] [review]
Make the WebGLContext a wrapper cache.
Attachment #617386 - Flags: review?(peterv)
Created attachment 617391 [details] [diff] [review]
Make the WebGLContext a wrapper cache.
Attachment #617391 - Flags: review?(peterv)
Attachment #617386 - Attachment is obsolete: true
Attachment #617386 - Flags: review?(peterv)
Created attachment 617394 [details] [diff] [review]
Make the WebGLContext a wrapper cache.
Attachment #617394 - Flags: review?(peterv)
Attachment #617391 - Attachment is obsolete: true
Attachment #617391 - Flags: review?(peterv)
Comment on attachment 617394 [details] [diff] [review]
Make the WebGLContext a wrapper cache.

Review of attachment 617394 [details] [diff] [review]:
-----------------------------------------------------------------

I think you also need to add a PreCreate hook :-/. Otherwise we might create a WN in a scope other than the parent object's scope, which is then the only real wrapper for that WebGLContext.
Aha!  Yes, makes sense.  That's why you're tagged as the reviewer!  ;)
Created attachment 617772 [details] [diff] [review]
With PreCreate hook
Attachment #617772 - Flags: review?(peterv)
Attachment #617394 - Attachment is obsolete: true
Attachment #617394 - Flags: review?(peterv)
Attachment #617772 - Flags: review?(peterv) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9369cb6d43e
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/c9369cb6d43e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.