Last Comment Bug 747826 - Make Nullable::Value return a const ref
: Make Nullable::Value return a const ref
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla15
Assigned To: Boris Zbarsky [:bz]
:
Mentors:
Depends on:
Blocks: 745897
  Show dependency treegraph
 
Reported: 2012-04-22 22:00 PDT by Boris Zbarsky [:bz]
Modified: 2012-04-26 10:31 PDT (History)
1 user (show)
bzbarsky: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Return the value inside a Nullable by reference, not by value, so Nullable around some sort of complex type works sanely. (739 bytes, patch)
2012-04-22 22:12 PDT, Boris Zbarsky [:bz]
peterv: review+
Details | Diff | Splinter Review

Description Boris Zbarsky [:bz] 2012-04-22 22:00:42 PDT
Otherwise things like Nullable< nsTArray<T> > really suck.
Comment 1 Boris Zbarsky [:bz] 2012-04-22 22:12:27 PDT
Created attachment 617388 [details] [diff] [review]
Return the value inside a Nullable by reference, not by value, so Nullable around some sort of complex type works sanely.
Comment 3 Ed Morley [:emorley] 2012-04-26 10:31:34 PDT
https://hg.mozilla.org/mozilla-central/rev/b1217ae2c260

Note You need to log in before you can comment on or make changes to this bug.