Last Comment Bug 747860 - Put vs2010 configurations into a common directory
: Put vs2010 configurations into a common directory
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: Mark Banner (:standard8, afk until Dec)
:
: Gregory Szorc [:gps]
Mentors:
Depends on:
Blocks: 748744
  Show dependency treegraph
 
Reported: 2012-04-23 02:34 PDT by Mark Banner (:standard8, afk until Dec)
Modified: 2012-04-25 06:36 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
The fix (2.98 KB, patch)
2012-04-23 02:34 PDT, Mark Banner (:standard8, afk until Dec)
ted: review+
Details | Diff | Splinter Review

Description Mark Banner (:standard8, afk until Dec) 2012-04-23 02:34:33 PDT
Created attachment 617429 [details] [diff] [review]
The fix

Although browser/ is the only one in mozilla-central using the vs2010-mozconfig files at the moment, it would be useful to other apps (e.g. in comm-central).

I'm proposing that we move it to build/win{32|64}/mozconfig.vs2010. This is a useful place for other applications, and is also consistent with the placing of the build/unix/mozconfig.linux and build/macosx/mozconfig.leopard files which also give compiler information for those platforms.
Comment 1 Ted Mielczarek [:ted.mielczarek] 2012-04-23 05:00:06 PDT
Comment on attachment 617429 [details] [diff] [review]
The fix

I have no objections.
Comment 2 Mozilla RelEng Bot 2012-04-23 05:46:34 PDT
Try run for 04e6625a737e is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=04e6625a737e
Results (out of 3 total builds):
    success: 3
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/bugzilla@standard8.plus.com-04e6625a737e
Comment 3 Mark Banner (:standard8, afk until Dec) 2012-04-23 06:10:57 PDT
Landed on birch:

https://hg.mozilla.org/projects/birch/rev/6bccdc1b2dfb

Note You need to log in before you can comment on or make changes to this bug.