Closed
Bug 747902
Opened 12 years ago
Closed 12 years ago
Readd --ion -m -n flags to shell for compatiblity
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: decoder, Assigned: decoder)
References
Details
Attachments
(1 file)
1.54 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
In bug 724751, --ion -n was made the default and several flags we're removed (--ion, -n and -m I think). This causes problems with automation in several ways: 1) The old behavior is rejected, causing problems when reproducing old bugs 2) The new behavior for --ion-eager (just specifying that option), causes instant segfault on all revisions before that flag change, leading to false positives in automation. We should re-add the flags and have them essentially no-op as they are default anyway. This change is crucial for JSBugMon and bisection of bug fixes.
Assignee | ||
Updated•12 years ago
|
Version: Trunk → Other Branch
Assignee | ||
Comment 1•12 years ago
|
||
Comment 2•12 years ago
|
||
Comment on attachment 617483 [details] [diff] [review] Patch Review of attachment 617483 [details] [diff] [review]: ----------------------------------------------------------------- Makes sense, thanks for taking this. ::: js/src/shell/js.cpp @@ +4977,2 @@ > || !op.addBoolOption('\0', "no-jm", "Disable the JaegerMonkey method JIT") > + || !op.addBoolOption('n', "typeinfer", "Enable type inference (default)") Nit: s/typeinfer/ti and s/methodjit/jm to match no-jm/no-ti.
Attachment #617483 -
Flags: review?(jdemooij) → review+
Comment 3•12 years ago
|
||
Pushed: https://hg.mozilla.org/projects/ionmonkey/rev/bc1833f2111e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•