Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Readd --ion -m -n flags to shell for compatiblity

RESOLVED FIXED

Status

()

Core
JavaScript Engine
--
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: decoder, Assigned: decoder)

Tracking

Other Branch
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
In bug 724751, --ion -n was made the default and several flags we're removed (--ion, -n and -m I think). This causes problems with automation in several ways:

1) The old behavior is rejected, causing problems when reproducing old bugs

2) The new behavior for --ion-eager (just specifying that option), causes instant segfault on all revisions before that flag change, leading to false positives in automation.

We should re-add the flags and have them essentially no-op as they are default anyway. This change is crucial for JSBugMon and bisection of bug fixes.
(Assignee)

Updated

5 years ago
Version: Trunk → Other Branch
(Assignee)

Updated

5 years ago
Blocks: 724751
No longer blocks: 676763
(Assignee)

Comment 1

5 years ago
Created attachment 617483 [details] [diff] [review]
Patch
Assignee: general → choller
Status: NEW → ASSIGNED
Attachment #617483 - Flags: review?(jdemooij)
Comment on attachment 617483 [details] [diff] [review]
Patch

Review of attachment 617483 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense, thanks for taking this.

::: js/src/shell/js.cpp
@@ +4977,2 @@
>          || !op.addBoolOption('\0', "no-jm", "Disable the JaegerMonkey method JIT")
> +        || !op.addBoolOption('n', "typeinfer", "Enable type inference (default)")

Nit: s/typeinfer/ti and s/methodjit/jm to match no-jm/no-ti.
Attachment #617483 - Flags: review?(jdemooij) → review+
Pushed:

https://hg.mozilla.org/projects/ionmonkey/rev/bc1833f2111e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.