747963 - Social sharing library: add ability to open/close the window with keyboard

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Webdev, task)

Description

[Chris More [:cmore]]

For accessibility and other reasons, please add the ability to open and close the social sharing window with the keyboard.

Comment 1

[Owen Coutts [:tallOwen]]

How about we close the dialogue when a user hits the escape key?

Comment 2

[Chris More [:cmore]]

(In reply to Owen Coutts [:tallOwen] from comment #1)
> How about we close the dialogue when a user hits the escape key?

That seems to make sense for closing, but for opening, you should be able to tab to the box, hit the space bar to open window and then tab through social services and finally space bar to share.

Comment 3

[Isac Lagerblad (:icaaq)]

(In reply to Chris More [:cmore] from comment #2)
> (In reply to Owen Coutts [:tallOwen] from comment #1)
> > How about we close the dialogue when a user hits the escape key?
> 
> That seems to make sense for closing, but for opening, you should be able to
> tab to the box, hit the space bar to open window and then tab through social
> services and finally space bar to share.

I think the the enter key should have the same behavior.

Comment 4

[Chris More [:cmore]]

Owen: is this something you will be able to finish before your last day or should I get another developer to do it?

Comment 5

[Owen Coutts [:tallOwen]]

Using the escape key to close the plugin has landed:

https://github.com/mozilla/SocialShare/commit/230f07b169b0746cefd06e23fa465969e81b6d7e

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Can we test this on http://people.mozilla.org/~ocoutts/collusion/, in a bit?

Comment 7

[Isac Lagerblad (:icaaq)]

I cant se how "close the plugin with escape key" can set this bug to resolved? if a keyboard user can't open this widget it's useless.

I've made a pull request to fix this https://github.com/mozilla/SocialShare/pull/25

Comment 8

[Chris More [:cmore]]

pmac: Can you check out the code and see what would need to be added to be able to open the window with a keyboard?

Comment 9

[Paul [:pmac] McLanahan]

Fixed in https://github.com/mozilla/SocialShare/commit/83aecb5576eee63e96d332d03bff0f727f42f021