Social sharing library: add ability to open/close the window with keyboard

RESOLVED FIXED

Status

RESOLVED FIXED
7 years ago
7 days ago

People

(Reporter: cmore, Assigned: pmac)

Tracking

({access})

Details

(Reporter)

Description

7 years ago
For accessibility and other reasons, please add the ability to open and close the social sharing window with the keyboard.
(Reporter)

Updated

7 years ago
Assignee: nobody → owen
How about we close the dialogue when a user hits the escape key?
(Reporter)

Comment 2

7 years ago
(In reply to Owen Coutts [:tallOwen] from comment #1)
> How about we close the dialogue when a user hits the escape key?

That seems to make sense for closing, but for opening, you should be able to tab to the box, hit the space bar to open window and then tab through social services and finally space bar to share.
(In reply to Chris More [:cmore] from comment #2)
> (In reply to Owen Coutts [:tallOwen] from comment #1)
> > How about we close the dialogue when a user hits the escape key?
> 
> That seems to make sense for closing, but for opening, you should be able to
> tab to the box, hit the space bar to open window and then tab through social
> services and finally space bar to share.

I think the the enter key should have the same behavior.
Keywords: access
OS: Mac OS X → All
Hardware: x86 → All
(Reporter)

Comment 4

7 years ago
Owen: is this something you will be able to finish before your last day or should I get another developer to do it?
Using the escape key to close the plugin has landed:

https://github.com/mozilla/SocialShare/commit/230f07b169b0746cefd06e23fa465969e81b6d7e
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
I cant se how "close the plugin with escape key" can set this bug to resolved? if a keyboard user can't open this widget it's useless.

I've made a pull request to fix this https://github.com/mozilla/SocialShare/pull/25
(Reporter)

Comment 8

7 years ago
pmac: Can you check out the code and see what would need to be added to be able to open the window with a keyboard?
Assignee: owen → pmclanahan
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Fixed in https://github.com/mozilla/SocialShare/commit/83aecb5576eee63e96d332d03bff0f727f42f021
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED

Updated

7 days ago
Product: mozilla.org → mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.