Last Comment Bug 748027 - Make the identity box transparent in more cases
: Make the identity box transparent in more cases
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: Firefox 14
Assigned To: Dão Gottwald [:dao]
:
Mentors:
Depends on:
Blocks: 742419
  Show dependency treegraph
 
Reported: 2012-04-23 11:32 PDT by Dão Gottwald [:dao]
Modified: 2012-04-23 12:42 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.48 KB, patch)
2012-04-23 11:32 PDT, Dão Gottwald [:dao]
jaws: review+
Details | Diff | Review
Screenshot with tabs on bottom (13.68 KB, image/jpeg)
2012-04-23 12:00 PDT, Siddhartha Dugar [:sdrocking]
no flags Details

Description Dão Gottwald [:dao] 2012-04-23 11:32:58 PDT
Created attachment 617558 [details] [diff] [review]
patch

On OS X we never need the white background, on Windows we can omit it when using a lightweight theme.
Comment 1 Siddhartha Dugar [:sdrocking] 2012-04-23 11:56:32 PDT
This is still needed on Windows with lightweight themes. Maybe a reduced opacity can help in such cases.

With the default theme on Windows the background of the url container is already white with tabs on top. With tabs on bottom the white identity box looks strange on glass. Reducing the opacity also fixes this case.
Comment 2 Siddhartha Dugar [:sdrocking] 2012-04-23 12:00:31 PDT
Created attachment 617582 [details]
Screenshot with tabs on bottom

On Windows 7 with default theme.
Comment 3 Dão Gottwald [:dao] 2012-04-23 12:14:27 PDT
http://hg.mozilla.org/mozilla-central/rev/937cdb639def

Note You need to log in before you can comment on or make changes to this bug.