Last Comment Bug 748040 - remove "memory hooking stuff" from cycle collector
: remove "memory hooking stuff" from cycle collector
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: Andrew McCreight [:mccr8]
:
Mentors:
Depends on:
Blocks: CleanupCC
  Show dependency treegraph
 
Reported: 2012-04-23 11:56 PDT by Andrew McCreight [:mccr8]
Modified: 2012-05-10 18:41 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
remove it (12.19 KB, patch)
2012-04-26 16:03 PDT, Andrew McCreight [:mccr8]
bugs: review+
Details | Diff | Splinter Review

Description Andrew McCreight [:mccr8] 2012-04-23 11:56:18 PDT
I'd be surprised if anybody has used this in a long time.  For instance, it is disabled on OSX.
Comment 1 Andrew McCreight [:mccr8] 2012-04-23 12:46:56 PDT
smaug said this is from 1.1, in Nov 22 2006.
Comment 2 Andrew McCreight [:mccr8] 2012-04-26 16:03:51 PDT
Created attachment 618838 [details] [diff] [review]
remove it
Comment 3 Andrew McCreight [:mccr8] 2012-04-26 16:04:29 PDT
I also removed a few things from nsCycleCollectorStats that are completely unused.
Comment 4 Andrew McCreight [:mccr8] 2012-05-10 07:28:56 PDT
Comment on attachment 618838 [details] [diff] [review]
remove it

Try run looked okay.
Comment 5 Olli Pettay [:smaug] 2012-05-10 07:54:02 PDT
Comment on attachment 618838 [details] [diff] [review]
remove it

Didn't I review this change already in some other bug... maybe not.
Comment 6 Andrew McCreight [:mccr8] 2012-05-10 08:01:07 PDT
Thanks.  You did look into when it was introduced, so maybe that was what you were thinking of?

https://hg.mozilla.org/integration/mozilla-inbound/rev/704ffa6c0791
Comment 7 Joe Drew (not getting mail) 2012-05-10 18:41:31 PDT
https://hg.mozilla.org/mozilla-central/rev/704ffa6c0791

Note You need to log in before you can comment on or make changes to this bug.