748071 - IonMonkey: "Assertion failure: !"Need to determine correct offsets for generateEnterJIT() args on Win64.","

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack

Object.defineProperty(this, "x", {
  get: function() {
    return x
  }
})
x

asserts js debug shell on IonMonkey changeset 9e64f779b611 without any CLI flags at Assertion failure: !"Need to determine correct offsets for generateEnterJIT() args on Win64.",

First 64-bit Windows bug!

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

This has been happening at least since:

http://hg.mozilla.org/projects/ionmonkey/rev/43b55878da46

and probably has existed since IonMonkey creation.

Comment 2

[Sean Stangl [:sstangl]]

It was introduced by Bug 723333. I need access to a Win64 box to verify the right argument offsets in ion/x64/Trampoline-x64.cpp:72-73.

Comment 3

[Sean Stangl [:sstangl]]

Attachment: Remove assertion.

After time spent learning Win64 debug tools with Gary's help, it turns out that the guessed values are actually valid. So we can just remove the assertion.

Comment 4

[Sean Stangl [:sstangl]]

Comment on attachment 617718 [details] [diff] [review]
Remove assertion.

mjrosenb offered a review, so I'm taking it!

Comment 5

[Sean Stangl [:sstangl]]

https://hg.mozilla.org/projects/ionmonkey/rev/ff010cbbec12