Note: There are a few cases of duplicates in user autocompletion which are being worked on.

IonMonkey: "Assertion failure: !"Need to determine correct offsets for generateEnterJIT() args on Win64.","

RESOLVED FIXED

Status

()

Core
JavaScript Engine
--
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gkw, Assigned: sstangl)

Tracking

(Blocks: 2 bugs, {assertion, testcase})

Other Branch
x86_64
Windows 7
assertion, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 617603 [details]
stack

Object.defineProperty(this, "x", {
  get: function() {
    return x
  }
})
x

asserts js debug shell on IonMonkey changeset 9e64f779b611 without any CLI flags at Assertion failure: !"Need to determine correct offsets for generateEnterJIT() args on Win64.",

First 64-bit Windows bug!
(Reporter)

Comment 1

5 years ago
This has been happening at least since:

http://hg.mozilla.org/projects/ionmonkey/rev/43b55878da46

and probably has existed since IonMonkey creation.
(Assignee)

Comment 2

5 years ago
It was introduced by Bug 723333. I need access to a Win64 box to verify the right argument offsets in ion/x64/Trampoline-x64.cpp:72-73.
(Assignee)

Comment 3

5 years ago
Created attachment 617718 [details] [diff] [review]
Remove assertion.

After time spent learning Win64 debug tools with Gary's help, it turns out that the guessed values are actually valid. So we can just remove the assertion.
Attachment #617718 - Flags: review?(dvander)
(Assignee)

Comment 4

5 years ago
Comment on attachment 617718 [details] [diff] [review]
Remove assertion.

mjrosenb offered a review, so I'm taking it!
Attachment #617718 - Flags: review?(dvander)
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/ff010cbbec12
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment #617718 - Flags: review+
(Reporter)

Updated

5 years ago
Assignee: general → sstangl
You need to log in before you can comment on or make changes to this bug.