748090 - pop3 filters that move new message to imap folders mostly won't work

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[David :Bienvenu]

pop3 incoming mail filters that move messages to imap folders mostly won't work. This is a regression from the pluggable store work. Prior to pluggable stores, we used a single new mail parser for all the messages in a pop3 download session. The moves to imap folders were coalesced by a imap move coalescer owned by the parser. Now, we use one new mail parser per message, which means the imap move coalescing doesn't work, except if the filter happens to apply to the last message downloaded in a download session.

Comment 1

[David :Bienvenu]

The relnote would be

pop3 filters that move/copy incoming messages to imap folders will not work, for the most part, except for the last message downloaded in get new mail operation. For this reason, it is probably best to disable such filters until this bug is fixed. Filters that are run manually should work.

Comment 2

[David :Bienvenu]

sadly, there's no way to do an automated test for this, so we'd have to fallback onto a litmus test.

Comment 3

[Wayne Mery (:wsmwk)]

should this not block bug 402392, rather than be blocked by bug 402392?

Comment 4

[David :Bienvenu]

(In reply to Wayne Mery (:wsmwk) from comment #3)
> should this not block bug 402392, rather than be blocked by bug 402392?

yeah, sorry, forgot to switch that.

Comment 5

[David :Bienvenu]

Attachment: proposed fix

This should fix it...

Comment 6

[David :Bienvenu]

Comment on attachment 617740 [details] [diff] [review]
proposed fix

this makes pop3 to imap filters work for me, and xpcshell tests all still pass.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 617740 [details] [diff] [review]
proposed fix

[Triage Comment]
a=me for landing regression fix on branches.

Comment 8

[Mark Banner (:standard8)]

Checked in:
https://hg.mozilla.org/comm-central/rev/2b4524d258f3
https://hg.mozilla.org/releases/comm-aurora/rev/2eef53f31fcf
https://hg.mozilla.org/releases/comm-beta/rev/9d82860ddf8d
https://hg.mozilla.org/releases/comm-release/rev/53fd7df65dba

Comment 9

[Mark Banner (:standard8)]

We relnoted this for 12.0 and its fixed in 12.0.1 & later so no need for relnote anymore.