Closed Bug 748197 Opened 11 years ago Closed 11 years ago

additional mozharness.base.python enhancements

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aki, Assigned: aki)

References

Details

(Whiteboard: [mozharness])

Attachments

(1 file)

I'm trying to pare down the differences between my talosrunner branch and default.
These are my talosrunner python/VirtualenvMixin changes.

* add a VirtualenvErrorList and use it
* don't die on error matches in install_module(); die on non-0 exit status.
** specifically because PyYAML throws a number of spurious errors while installing
* check for an existing virtualenv.  Running with an existing virtualenv activated causes me issues, but I wasn't sure whether I wanted to fatal() here.

I'd be interested in your thoughts here.
Attachment #617725 - Flags: review?(jhammel)
Comment on attachment 617725 [details] [diff] [review]
virtualenv enhancements

This works for me, since checking for an existing virtualenv is non-fatal.  FWIW, I always run mozharness (and just about all other python software) in a virtualenv and haven't had problems creating sub-virtualenvs in "sane" environments.  I will note in passing, however, that if PYTHONHOME is set, bad things do happen o_O
Attachment #617725 - Flags: review?(jhammel) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → Mozharness
You need to log in before you can comment on or make changes to this bug.