748197 - additional mozharness.base.python enhancements

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Aki Sasaki (not active)]

Attachment: virtualenv enhancements

I'm trying to pare down the differences between my talosrunner branch and default.
These are my talosrunner python/VirtualenvMixin changes.

* add a VirtualenvErrorList and use it
* don't die on error matches in install_module(); die on non-0 exit status.
** specifically because PyYAML throws a number of spurious errors while installing
* check for an existing virtualenv.  Running with an existing virtualenv activated causes me issues, but I wasn't sure whether I wanted to fatal() here.

I'd be interested in your thoughts here.

Comment 1

[Jeff Hammel]

Comment on attachment 617725 [details] [diff] [review]
virtualenv enhancements

This works for me, since checking for an existing virtualenv is non-fatal.  FWIW, I always run mozharness (and just about all other python software) in a virtualenv and haven't had problems creating sub-virtualenvs in "sane" environments.  I will note in passing, however, that if PYTHONHOME is set, bad things do happen o_O

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 617725 [details] [diff] [review]
virtualenv enhancements

http://hg.mozilla.org/build/mozharness/rev/d2c8c258aa86