748209 - Allow compositorParent be created in custom Thread

Status: RESOLVED FIXED

Description

[Oleg Romashin (:romaxa)]

For OMTC embedding setup I need to run CompositorParent in native toolkit thread, and message loop merged with native main loop.

Instead of taking Thread as argument we can take message loop + thread ID.

Comment 1

[Oleg Romashin (:romaxa)]

Created attachment 617759 [details] [diff] [review]
Allow custom loop and thread for CpmpositorParent

Comment 2

[Oleg Romashin (:romaxa)]

Created attachment 617762 [details] [diff] [review]
Allow custom loop and thread for CpmpositorParent

Err, forgot to remove mThread from init list. fixed here.
hope try will be ok
https://tbpl.mozilla.org/?tree=Try&rev=5b5b733c1868

Comment 3

[Oleg Romashin (:romaxa)]

Created attachment 617796 [details] [diff] [review]
Allow to create useful SubClass from CompositorParent

This is minimal patch which allow to create usable CompositorParent subclass.

Comment 4

[Ali Juma [:ajuma]]

(In reply to Oleg Romashin (:romaxa) from comment #2)
> Created attachment 617762 [details] [diff] [review]
> Allow custom loop and thread for CpmpositorParent
> 
> Err, forgot to remove mThread from init list. fixed here.
> hope try will be ok
> https://tbpl.mozilla.org/?tree=Try&rev=5b5b733c1868

There are some failures here. You might just have pulled a bad revision, but please look into this before landing.

Comment 5

[Oleg Romashin (:romaxa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81a2421803e1
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef22d77a1d51

Comment 6

[:Ehsan Akhgari]

https://hg.mozilla.org/mozilla-central/rev/ef22d77a1d51
https://hg.mozilla.org/mozilla-central/rev/81a2421803e1

Comment 7

[Benoit Girard (:BenWa)]

jgilbert points out that the code here is incorrect:
http://mxr.mozilla.org/mozilla-central/source/gfx/layers/ipc/CompositorParent.cpp#188

it should be |if (!time)| or better yet |if (time != 0)|

Comment 8

[Benoit Girard (:BenWa)]

Created attachment 626858 [details] [diff] [review]
fallout fix

Comment 9

[Benoit Girard (:BenWa)]

Created attachment 626859 [details] [diff] [review]
real fix

Comment 10

[Oleg Romashin (:romaxa)]

Oh :(

Comment 11

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1f60ba0301b2

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1f60ba0301b2