The default bug view has changed. See this FAQ.

Allow compositorParent be created in custom Thread

RESOLVED FIXED in mozilla15

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

unspecified
mozilla15
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Assignee)

Description

5 years ago
For OMTC embedding setup I need to run CompositorParent in native toolkit thread, and message loop merged with native main loop.

Instead of taking Thread as argument we can take message loop + thread ID.
(Assignee)

Comment 1

5 years ago
Created attachment 617759 [details] [diff] [review]
Allow custom loop and thread for CpmpositorParent
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #617759 - Flags: review?(ajuma)
(Assignee)

Comment 2

5 years ago
Created attachment 617762 [details] [diff] [review]
Allow custom loop and thread for CpmpositorParent

Err, forgot to remove mThread from init list. fixed here.
hope try will be ok
https://tbpl.mozilla.org/?tree=Try&rev=5b5b733c1868
Attachment #617759 - Attachment is obsolete: true
Attachment #617759 - Flags: review?(ajuma)
Attachment #617762 - Flags: review?(ajuma)
(Assignee)

Comment 3

5 years ago
Created attachment 617796 [details] [diff] [review]
Allow to create useful SubClass from CompositorParent

This is minimal patch which allow to create usable CompositorParent subclass.
Attachment #617796 - Flags: review?(ajuma)

Updated

5 years ago
Attachment #617762 - Flags: review?(ajuma) → review+

Comment 4

5 years ago
(In reply to Oleg Romashin (:romaxa) from comment #2)
> Created attachment 617762 [details] [diff] [review]
> Allow custom loop and thread for CpmpositorParent
> 
> Err, forgot to remove mThread from init list. fixed here.
> hope try will be ok
> https://tbpl.mozilla.org/?tree=Try&rev=5b5b733c1868

There are some failures here. You might just have pulled a bad revision, but please look into this before landing.

Updated

5 years ago
Attachment #617796 - Flags: review?(ajuma) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/81a2421803e1
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef22d77a1d51
https://hg.mozilla.org/mozilla-central/rev/ef22d77a1d51
https://hg.mozilla.org/mozilla-central/rev/81a2421803e1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
jgilbert points out that the code here is incorrect:
http://mxr.mozilla.org/mozilla-central/source/gfx/layers/ipc/CompositorParent.cpp#188

it should be |if (!time)| or better yet |if (time != 0)|

Updated

5 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 626858 [details] [diff] [review]
fallout fix
Attachment #626858 - Flags: review?

Updated

5 years ago
Attachment #626858 - Flags: review? → review?(ajuma)
Created attachment 626859 [details] [diff] [review]
real fix
Attachment #626858 - Attachment is obsolete: true
Attachment #626858 - Flags: review?(ajuma)
Attachment #626859 - Flags: review?(ajuma)

Updated

5 years ago
Attachment #626859 - Flags: review?(ajuma) → review+
(Assignee)

Comment 10

5 years ago
Oh :(
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f60ba0301b2
https://hg.mozilla.org/mozilla-central/rev/1f60ba0301b2
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.