Closed Bug 748209 Opened 9 years ago Closed 9 years ago

Allow compositorParent be created in custom Thread

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: romaxa, Assigned: romaxa)

References

Details

Attachments

(3 files, 2 obsolete files)

Allow custom loop and thread for CpmpositorParent
7.67 KB, patch
ajuma
: review+
Details | Diff | Splinter Review
Allow to create useful SubClass from CompositorParent
2.78 KB, patch
ajuma
: review+
Details | Diff | Splinter Review
real fix
719 bytes, patch
ajuma
: review+
Details | Diff | Splinter Review 
For OMTC embedding setup I need to run CompositorParent in native toolkit thread, and message loop merged with native main loop.

Instead of taking Thread as argument we can take message loop + thread ID.
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #617759 - Flags: review?(ajuma)
Err, forgot to remove mThread from init list. fixed here.
hope try will be ok
https://tbpl.mozilla.org/?tree=Try&rev=5b5b733c1868
Attachment #617759 - Attachment is obsolete: true
Attachment #617759 - Flags: review?(ajuma)
Attachment #617762 - Flags: review?(ajuma)
This is minimal patch which allow to create usable CompositorParent subclass.
Attachment #617796 - Flags: review?(ajuma)
Attachment #617762 - Flags: review?(ajuma) → review+
(In reply to Oleg Romashin (:romaxa) from comment #2)
> Created attachment 617762 [details] [diff] [review]
> Allow custom loop and thread for CpmpositorParent
> 
> Err, forgot to remove mThread from init list. fixed here.
> hope try will be ok
> https://tbpl.mozilla.org/?tree=Try&rev=5b5b733c1868

There are some failures here. You might just have pulled a bad revision, but please look into this before landing.
Attachment #617796 - Flags: review?(ajuma) → review+
https://hg.mozilla.org/mozilla-central/rev/ef22d77a1d51
https://hg.mozilla.org/mozilla-central/rev/81a2421803e1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
jgilbert points out that the code here is incorrect:
http://mxr.mozilla.org/mozilla-central/source/gfx/layers/ipc/CompositorParent.cpp#188

it should be |if (!time)| or better yet |if (time != 0)|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch fallout fix (obsolete) — — Splinter Review
Attachment #626858 - Flags: review?
Attachment #626858 - Flags: review? → review?(ajuma)
Attached patch real fix — — Splinter Review
Attachment #626858 - Attachment is obsolete: true
Attachment #626858 - Flags: review?(ajuma)
Attachment #626859 - Flags: review?(ajuma)
Attachment #626859 - Flags: review?(ajuma) → review+
Oh :(
https://hg.mozilla.org/mozilla-central/rev/1f60ba0301b2
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.