Closed
Bug 748209
Opened 10 years ago
Closed 10 years ago
Allow compositorParent be created in custom Thread
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: romaxa, Assigned: romaxa)
References
Details
Attachments
(3 files, 2 obsolete files)
7.67 KB,
patch
|
ajuma
:
review+
|
Details | Diff | Splinter Review |
2.78 KB,
patch
|
ajuma
:
review+
|
Details | Diff | Splinter Review |
719 bytes,
patch
|
ajuma
:
review+
|
Details | Diff | Splinter Review |
For OMTC embedding setup I need to run CompositorParent in native toolkit thread, and message loop merged with native main loop. Instead of taking Thread as argument we can take message loop + thread ID.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Err, forgot to remove mThread from init list. fixed here. hope try will be ok https://tbpl.mozilla.org/?tree=Try&rev=5b5b733c1868
Attachment #617759 -
Attachment is obsolete: true
Attachment #617759 -
Flags: review?(ajuma)
Attachment #617762 -
Flags: review?(ajuma)
Assignee | ||
Comment 3•10 years ago
|
||
This is minimal patch which allow to create usable CompositorParent subclass.
Attachment #617796 -
Flags: review?(ajuma)
Updated•10 years ago
|
Attachment #617762 -
Flags: review?(ajuma) → review+
Comment 4•10 years ago
|
||
(In reply to Oleg Romashin (:romaxa) from comment #2) > Created attachment 617762 [details] [diff] [review] > Allow custom loop and thread for CpmpositorParent > > Err, forgot to remove mThread from init list. fixed here. > hope try will be ok > https://tbpl.mozilla.org/?tree=Try&rev=5b5b733c1868 There are some failures here. You might just have pulled a bad revision, but please look into this before landing.
Updated•10 years ago
|
Attachment #617796 -
Flags: review?(ajuma) → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/81a2421803e1 https://hg.mozilla.org/integration/mozilla-inbound/rev/ef22d77a1d51
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ef22d77a1d51 https://hg.mozilla.org/mozilla-central/rev/81a2421803e1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Comment 7•10 years ago
|
||
jgilbert points out that the code here is incorrect: http://mxr.mozilla.org/mozilla-central/source/gfx/layers/ipc/CompositorParent.cpp#188 it should be |if (!time)| or better yet |if (time != 0)|
Updated•10 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 8•10 years ago
|
||
Attachment #626858 -
Flags: review?
Updated•10 years ago
|
Attachment #626858 -
Flags: review? → review?(ajuma)
Comment 9•10 years ago
|
||
Attachment #626858 -
Attachment is obsolete: true
Attachment #626858 -
Flags: review?(ajuma)
Attachment #626859 -
Flags: review?(ajuma)
Updated•10 years ago
|
Attachment #626859 -
Flags: review?(ajuma) → review+
Assignee | ||
Comment 10•10 years ago
|
||
Oh :(
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1f60ba0301b2
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•