Move test_bug514437.html and test_bug588683-*.html to content/html/content/tests/forms/

RESOLVED FIXED in mozilla15

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mounir, Assigned: Alice Lieutier)

Tracking

Trunk
mozilla15
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=mounir][good first bug])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Tests in content/html/content/tests/forms/ are only about form controls and try to follow some good practices like having a real test name and test large features instead of small bugs.

Some tests in content/html/content/tests/ could be moved in this directory and I found a few of them recently:
content/html/content/test/test_bug514437.html should be moved to content/html/content/test/forms/test_progress_element.html
and:
content/html/content/test/test_bug588683-*.html should be moved to content/html/content/test/forms/test_form_attribute-*.html

In addition of moving the tests, you can change the <title> and change the top comment (like /** Test for Bug XXXXX **/) to be more explicit about what the test is actually doing.

This is a very good first bug because the hard parts are using mercurial and bugzilla.
(Reporter)

Comment 1

5 years ago
Some documentation that might help:
https://developer.mozilla.org/en/Introduction

A lot of interesting pages are linked from there.
(Reporter)

Comment 2

5 years ago
I forgot to say that Mochitests are listed in Makefile.in (in the same directory). These files will have to be modified.

More information about mochitests:
https://developer.mozilla.org/en/Mochitest
(Assignee)

Comment 3

5 years ago
Created attachment 618461 [details] [diff] [review]
patch1

I made all the changes asked for.

I had to slightly change test_progress_element.html so it would pass from the new location in test/forms.
Attachment #618461 - Flags: review?(mounir)
(Reporter)

Comment 4

5 years ago
Comment on attachment 618461 [details] [diff] [review]
patch1

Review of attachment 618461 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good but the patch doesn't move the test files. How did you generate it?
Attachment #618461 - Flags: review?(mounir)
(Reporter)

Updated

5 years ago
Assignee: nobody → alice.lieutier
(Reporter)

Comment 5

5 years ago
Comment on attachment 618461 [details] [diff] [review]
patch1

Review of attachment 618461 [details] [diff] [review]:
-----------------------------------------------------------------

My bad, our tool (splinter review) just doesn't show that information. Neither do the diff view nor the "raw" view from the diff page...
Attachment #618461 - Flags: review+
(Reporter)

Updated

5 years ago
Flags: in-testsuite+
Target Milestone: --- → mozilla15
(Reporter)

Comment 6

5 years ago
Comment on attachment 618461 [details] [diff] [review]
patch1

Patch pushed to mozilla-inbound. Should be merged to mozilla-central soon.

Congrats for your first patch ;)
Attachment #618461 - Flags: checkin+

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f0dc48f621b9

Congrats on your first patch! Come and join us on IRC (https://wiki.mozilla.org/IRC) on #developers and we'll find something else you can work on if you are interested? :-)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.