Last Comment Bug 748254 - A font-face descriptor ending in ',' right before the '}' makes us miss the '}'
: A font-face descriptor ending in ',' right before the '}' makes us miss the '}'
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla15
Assigned To: Boris Zbarsky [:bz]
:
Mentors:
Depends on: 790997
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-23 23:54 PDT by Boris Zbarsky [:bz]
Modified: 2012-09-13 15:09 PDT (History)
2 users (show)
bzbarsky: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Testcase (138 bytes, text/html)
2012-04-23 23:54 PDT, Boris Zbarsky [:bz]
no flags Details
When we encounter an unexpected '}' terminating a font-face descriptor's value, correctly close the font-face rule instead of eating the rest of the stylesheet. (2.40 KB, patch)
2012-04-24 13:07 PDT, Boris Zbarsky [:bz]
dbaron: review+
Details | Diff | Splinter Review

Description Boris Zbarsky [:bz] 2012-04-23 23:54:40 PDT
Created attachment 617805 [details]
Testcase

See attached testcase.
Comment 1 Boris Zbarsky [:bz] 2012-04-24 13:07:52 PDT
Created attachment 618008 [details] [diff] [review]
When we encounter an unexpected '}' terminating a font-face descriptor's value, correctly close the font-face rule instead of eating the rest of the stylesheet.
Comment 2 David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2012-04-24 13:32:43 PDT
Comment on attachment 618008 [details] [diff] [review]
When we encounter an unexpected '}' terminating a font-face descriptor's value, correctly close the font-face rule instead of eating the rest of the stylesheet.

r=dbaron
Comment 4 Ed Morley [:emorley] 2012-04-26 10:34:39 PDT
https://hg.mozilla.org/mozilla-central/rev/10c3731c3d95

Note You need to log in before you can comment on or make changes to this bug.