748291 - Conditional forward button code broken when urlbar extended

Status: UNCONFIRMED

(Core :: XUL, defect)

Description

[Neil Bird]

Attachment: bad.png - extension being mis-drawn

User Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20100101 Firefox/11.0
Build ID: 20120312181643

Steps to reproduce:

Install Neo Diggler extension: https://addons.mozilla.org/en-US/firefox/addon/neo-diggler/ (note, I maintain this, but didn't originally write it).



Actual results:

The extra attachment to the URL bar gets misdrawn mostly under the LHS of the URL bar, and cannot be clicked.  See “bad.png” attachment.


Expected results:

The extra bit should be visible and have a button+menu.  See “ok.png” attachment.

I've had a look at the FF source, but can't find exactly where this would be happening.  The extension puts itself at the front of the urlbar-container via a XUL overlay:

  <hbox id="urlbar-container">
    <toolbarbutton id="diggler-button" position="1"/>
    <tooltip id="diggler-tooltip"/>
  </hbox>

It seems that the optional-forward-button code is making some presumptions about the content of the width of the urlbar proper, although it does get it right for other urlbar manipulators (e.g,. read-it-later extension, which adds an icon to the *end* of the inner urlbar).


I've taken snapshots under Linux, but the same thing happens under Windows.  However, on Windows the case is more complicated by the back button actually attaching itself (normally) to the URL bar, so I'm not sure what the solution there would be.

It all works “correctly” if something is put between the for/back buttons (even a sep.), but I understand that this is deliberate in that the clever forward button only works when next the to the URL bar (which does make sense for the Windows skin but seems limited for the Linux skin where you could still have a fading forward button, but still).


If a Firefox fix itself is not obvious, I'm open to suggestions as to how to fix things from the extention's front.

Comment 1

[Neil Bird]

Attachment: ok.png - extension being drawn correctly