748311 - makefiles: add function nsinstall_mkdir_deps

Status: NEW

(Firefox Build System :: General, defect)

Description

[Joey Armstrong [:joey]]

Add a new mkdir_deps function for nsinstall related targets to reduce directory creation calls.

config/makefiles/autotargets.mk
js/src/config/makefiles/autotargets.mk
=======================================

nsinstall_mkdir_deps = \
  $(checkIfEmpty,NSINSTALL)\
  $(foreach dir,$(getargv),.deps/$(dir)/.mkdir.deps.nsinstall)
  $(NULL)

%/.mkdir.deps.nsinstall:
   $(NSINSTALL) -D $(subst .deps/,$(NULL),$*) && $(MKDIR) -p $* && $(TOUCH) $@

Comment 1

[(not currently active) Ted Mielczarek]

I don't think there's any reason to prefer this over your existing mkdir rules. Can you show an instance where something special is required? AFAICT, nsinstall -D is roughly equivalent to mkdir -p, so this seems redundant.

Comment 2

[Joey Armstrong [:joey]]

(In reply to Ted Mielczarek [:ted] from comment #1)
> I don't think there's any reason to prefer this over your existing mkdir
> rules. Can you show an instance where something special is required? AFAICT,
> nsinstall -D is roughly equivalent to mkdir -p, so this seems redundant.

The extra layer was used to avoid creating a token file in the destination directory { dist/, classes/, etc } where it might be packaged for distribution.  Create the destination and place timestamp under .deps/

If we can rely on umask + mkdir -p and drop nsinstall -D that would be a simpler setup all around.

Comment 3

[(not currently active) Ted Mielczarek]

Ah, good point. Note that for actual packaging we have an explicit package manifest, so nothing outside of that gets packaged. For other things this might be a concern. (I noticed that we had extraneous .mkdir.done files in the test package, for example, but those are harmless where they appeared.)