748425 - [socorro-crashstats] /topcrasher/byversion/Firefox should go to a featured version

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Robert Kaiser]

While writing a blog post where I wanted a generic reference to a TCBS report, I tried calling up https://crash-stats.mozilla.com/topcrasher/byversion/Firefox and was positively surprised that it works, but negatively surprised that it did go to 12.0, which currently isn't featured (yet - will be soon).
This URL should go to a featured version, I don't care too much which one. As selecting "Top Crashers" from the dropdown on the front page goes to the top featured item in the version list, I guess that would be best for consistency.

Comment 1

[Schalk Neethling [:espressive]]

[:kairo] Spoke to Laura about this, and even though passing 'Featured' gives us what we need right now, it is a happy coincidence rather than an expected result. As such, please update this bug with what you would ideally want for both:

1) When top crashers is accessed from the front page without selecting a version
2) When accessing a URL such as https://crash-stats.mozilla.com/topcrasher/byversion/Firefox directly

Thanks

Comment 2

[Robert Kaiser]

For one thing, I'd expect the same to happen in both those cases listed in comment #1.

For the other, I'd expect us to always go to a featured version, preferably the the most stable one and in case of multiple at same level, the newest one.

So, ideally, we'd do a list of featured versions ordered by channel stability (ESR > Release > Beta > Aurora > Nightly) first and newest-version-first second, and take the first entry of that list. Now, I guess, that's almost verbalized SQL already. ;-)

Comment 3

[[:jberkus] Josh Berkus]

So for version 11 I've added two new columns in product_info, product_sort and channel_sort, which allow choosing a default version.

However, to make life *even easier*, I've added the dynamic view default_versions.  It has one default version for each product.  So you can just pick from that.

All of this and more in Pull Request 608:  https://github.com/mozilla/socorro/pull/608

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/7c65edb1797f3ef27c9de0efeedae67c372f91de
Added default_versions view per bug 748425

Comment 5

[[github robot]]

Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/7c65edb1797f3ef27c9de0efeedae67c372f91de
Added default_versions view per bug 748425

Comment 6

[[github robot]]

Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/7b36dd1503f6c160b7788d6a290cc7fc2505f5e0
Added default_versions view per bug 748425

Comment 7

[[github robot]]

Commit pushed to admin-refactor at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/7c65edb1797f3ef27c9de0efeedae67c372f91de
Added default_versions view per bug 748425

Comment 8

[[github robot]]

Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/a53fe6c1ee1ca978f490e4a4596eeaec3d86f378
Added default_versions view per bug 748425

Comment 9

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/a53fe6c1ee1ca978f490e4a4596eeaec3d86f378
Added default_versions view per bug 748425

Comment 10

[Schalk Neethling [:espressive]]

Sent pull request: https://github.com/mozilla/socorro/pull/768

TEST CASE
---------

If a user navigates directly to top crashers or navigates to top crashers without selecting a version, the report and the version drop down should be for the default featured version.

P.S. I am unsure how one would determine the latest default featured version but, it seems to be the latest public stable release.

Comment 11

[Schalk Neethling [:espressive]]

I am wondering, is this not already fixed in socorro-crashstats?

Comment 12

[Robert Helmer [:rhelmer]]

(In reply to Schalk Neethling [:espressive] from comment #11)
> I am wondering, is this not already fixed in socorro-crashstats?

Yes this is implemented in the view right now:

https://github.com/mozilla/socorro-crashstats/blob/master/crashstats/crashstats/views.py#L137

I plan to uplift this kind of thing into a more general function in bug 789334 since it's a common need for different reports.

Comment 13

[Schalk Neethling [:espressive]]

This has been resolved in socorro-crashstats.

Comment 14

[Matt Brandt [:mbrandt]]

Thanks espressive and kairo -- verified on crash-stats-new-dev.allizom.org. Verified per steps in comment 10.