crash in nsMsgDatabase::MatchDbName

VERIFIED FIXED in Thunderbird 15.0

Status

defect
--
critical
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: wsmwk, Assigned: Bienvenu)

Tracking

({crash, regression, topcrash})

Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird12 fixed, thunderbird13 fixed, thunderbird14 fixed)

Details

(Whiteboard: [startupcrash][fixed in 12.0.1], crash signature)

Attachments

(1 attachment)

This bug was filed from the Socorro interface and is 
report bp-9a3223f4-2add-400b-af0a-065942120424 .
============================================================= 

starting in version 12. not seen in beta or alpha.
top 5 crash at present.  about half are startup crash

0	xul.dll	nsMsgDatabase::MatchDbName	mailnews/db/msgdb/src/nsMsgDatabase.cpp:968
1	xul.dll	nsMsgDatabase::FindInCache	mailnews/db/msgdb/src/nsMsgDatabase.cpp:936
2	xul.dll	nsMsgDBService::OpenFolderDB	mailnews/db/msgdb/src/nsMsgDatabase.cpp:134
3	xul.dll	nsImapMailFolder::GetDatabase	mailnews/imap/src/nsImapMailFolder.cpp:641
4	xul.dll	nsImapMailFolder::GetDBFolderInfoAndDB	mailnews/imap/src/nsImapMailFolder.cpp:2118
5	xul.dll	nsMsgDBFolder::ReadDBFolderInfo	mailnews/base/util/nsMsgDBFolder.cpp:664
6	xul.dll	nsMsgDBFolder::GetFlags	mailnews/base/util/nsMsgDBFolder.cpp:1268
7	xul.dll	nsImapIncomingServer::GetNewMessagesForNonInboxFolders	mailnews/imap/src/nsImapIncomingServer.cpp:3043
8	xul.dll	nsImapMailFolder::GetNewMessages	mailnews/imap/src/nsImapMailFolder.cpp:2629
9	xul.dll	nsImapIncomingServer::PerformBiff	mailnews/imap/src/nsImapIncomingServer.cpp:1027
10	xul.dll	NS_InvokeByIndex_P	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102
Posted patch possible fixSplinter Review
Assignee: nobody → dbienvenu
Attachment #617952 - Flags: review?(mbanner)
I haven't been able to recreate this crash, but I believe this should fix it.

From this stack, it looks like the user has most likely set the hidden pref to check for new messages in all folders, and one or more of the folders is causing us a problem. I can generate a try server build with the fix if you want to contact some of the users having this issue.
Attachment #617952 - Flags: review?(mbanner) → review+
fix landed on trunk - http://hg.mozilla.org/comm-central/rev/406d1046698a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
Comment on attachment 617952 [details] [diff] [review]
possible fix

[Approval Request Comment]
bulletproofing fix.
Attachment #617952 - Flags: approval-comm-beta?
Attachment #617952 - Flags: approval-comm-aurora?
do we know the cause of the regression?

fixed https://getsatisfaction.com/mozilla_messaging/topics/v12_crashing_wont_run_revert_to_last_version // bp-922a4c66-9dcb-486c-9663-000ad2120424

and as bienvenu suspected, also reporter of bp-052e8497-7b3b-4c89-8827-b965d2120425 Bug 748770 - startup crash in nsMsgDatabase::OpenInternal
(In reply to Wayne Mery (:wsmwk) from comment #6)
> do we know the cause of the regression?
presumably, pluggable store work, though I think there has to be something specifically weird about their profiles, since no one saw this in alpha or beta.
Attachment #617952 - Flags: approval-comm-beta?
Attachment #617952 - Flags: approval-comm-beta+
Attachment #617952 - Flags: approval-comm-aurora?
Attachment #617952 - Flags: approval-comm-aurora+
Blocks: 402392
70% are startup.
bp-3ce84a7a-4b41-46d5-9006-db85c2120425 (v15) a rare crash of daily
Keywords: topcrash
Whiteboard: [startupcrash]
OS: Windows NT → All
Hardware: x86 → All
Crash Signature: [@ nsMsgDatabase::MatchDbName(nsILocalFile*)] → [@ nsMsgDatabase::MatchDbName(nsILocalFile*)] [@ nsMsgDatabase::OpenInternal(nsILocalFile*, bool, bool, bool)]
Comment on attachment 617952 [details] [diff] [review]
possible fix

[Triage Comment]
Attachment #617952 - Flags: approval-comm-release+
v.fixed in 12.0.1 per crash-stats
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.