eliminate relocations required by gHistograms

RESOLVED FIXED in mozilla18

Status

()

Toolkit
Telemetry
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla18
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
bug 748417 is going to write a python script to parse TelemetryHistograms.h.  Once that's written, we should use the script to generate gHistograms at compile time; doing that will enable eliminating the pointers to names and descriptions (can simply use indices into a global char[] instead), reducing relocations and footprint.
(Assignee)

Comment 1

5 years ago
Created attachment 656475 [details] [diff] [review]
patch

I realize StringTable is a little overkill, but I copied the code directly from quickstubs, so I know it works, and if we start annotating histograms with units, we'll need something like StringTable anyway.  So I'd like to keep it around.
Assignee: nobody → nfroyd
Status: NEW → ASSIGNED
Attachment #656475 - Flags: review?(taras.mozilla)

Comment 2

5 years ago
Comment on attachment 656475 [details] [diff] [review]
patch

rubberstamp
Attachment #656475 - Flags: review?(taras.mozilla) → review+

Comment 3

5 years ago
What are the footprint wins here?
(Assignee)

Comment 4

5 years ago
(In reply to Taras Glek (:taras) from comment #3)
> What are the footprint wins here?

N histograms * (2 relocations + 1 word).  More than 1k bytes, less than 10k bytes on x86/ARM Linux.  Might be the same range for x86-64/Linux.  I imagine it's roughly the same on Windows and OS X, but not really sure.
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8b7d2524e94
https://hg.mozilla.org/mozilla-central/rev/a8b7d2524e94
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.