|
1.22 KB,
patch
|
mfinkle
:
review+
mfinkle
:
approval-mozilla-aurora+
mfinkle
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
|
1.81 KB,
patch
|
mfinkle
:
review+
mfinkle
:
approval-mozilla-aurora+
mfinkle
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/php/getParsedLog.php?id=11172420&tree=Mozilla-Beta https://tbpl.mozilla.org/php/getParsedLog.php?id=11167864&tree=Mozilla-Beta https://tbpl.mozilla.org/php/getParsedLog.php?id=11170275&tree=Mozilla-Beta
|
(Assignee) | |
Comment 1•5 years ago
|
||
Created attachment 618110 [details] [diff] [review] patch Alternately we could just disable or hide robocop on beta since we are never shipping native Fennec 13 on any channel.
|
||
Comment 2•5 years ago
|
||
Comment on attachment 618110 [details] [diff] [review] patch might as well fix it for the next train
|
|
(Assignee) | |
Comment 3•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f124e0fb5604
|
|
(Assignee) | |
Comment 4•5 years ago
|
||
Comment on attachment 618110 [details] [diff] [review] patch [Approval Request Comment] One-line test-only change to allow this test to pass on beta-branded builds.
| Comment hidden (Treeherder Robot) |
|
|
||
Comment 6•5 years ago
|
||
Comment on attachment 618110 [details] [diff] [review] patch tests only and limited to android.
https://hg.mozilla.org/mozilla-central/rev/f124e0fb5604
|
||
Updated•5 years ago
|
||
|
|
||
Updated•5 years ago
|
||
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
|
|
(Assignee) | |
Comment 10•5 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/9a8c1d5f3912
| Comment hidden (Treeherder Robot) |
|
|
(Assignee) | |
Comment 12•5 years ago
|
||
This did not fix the problem. Downloading and running the tinderbox build from the beta channel, it looks like there are actually no default bookmarks created in a new profile. Nominating as a beta blocker, because this breaks the first-run experience in builds on the beta channel.
|
|
(Assignee) | |
Comment 13•5 years ago
|
||
The bookmarks aren't created in beta 13 because bug 728224 never landed on aurora for version 13. I'm a little curious why this test was green on Aurora but orange after moving to beta, but in any case it doesn't affect our planned release. I've hidden robocop on beta for now, since we are never shipping native fennec from the 13.0 branch.
|
(Reporter) | |
Comment 14•5 years ago
|
||
Alas, once I finally remembered to unhide robocop for 14-on-beta, seems to be more about beta than about 13-on-beta.
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
| Comment hidden (Treeherder Robot) |
|
|
(Assignee) | |
Comment 23•5 years ago
|
||
Created attachment 631077 [details] [diff] [review] patch 2 Oops, the original patch here never landed on Aurora for Firefox 14. Now it needs to land on Beta 14. In addition, this patch fixes some additional errors that we'll hit on beta after the first patch lands. [Approval Request Comment] User impact if declined: Robocop tests are never green on beta. Risk to taking this patch (and alternatives if risky): Mobile-only test-only fix, to a test that is currently perma-orange. String or UUID changes made by this patch: None.
|
|
||
Comment 24•5 years ago
|
||
Comment on attachment 631077 [details] [diff] [review] patch 2 mobile-only, test-only
|
|
(Assignee) | |
Comment 25•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fee41489074
|
|
(Assignee) | |
Comment 26•5 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/91d3e124dee2 (includes both patches, folded) https://hg.mozilla.org/releases/mozilla-aurora/rev/77cf49ff4b57
| Comment hidden (Treeherder Robot) |
|
||
Comment 28•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6fee41489074 (Merged by Ed Morley)
Description
•