Closed Bug 748609 Opened 8 years ago Closed 8 years ago

Permaorange on mozilla-beta testAboutPage | page title match - about: page title is correct

Categories

(Firefox for Android :: General, defect)

Product:
Firefox for Android
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 16
Tracking Flags:
Tracking Status
firefox13 --- wontfix
firefox14 --- fixed
firefox15 --- fixed
blocking-fennec1.0 --- -

People

(Reporter: philor, Assigned: mbrubeck)

References

Details

(Whiteboard: [perma-orange])

Attachments

(2 files)

patch
1.22 KB, patch
mfinkle
: review+
mfinkle
: approval-mozilla-aurora+
mfinkle
: approval-mozilla-beta+
Details | Diff | Splinter Review
patch 2
1.81 KB, patch
mfinkle
: review+
mfinkle
: approval-mozilla-aurora+
mfinkle
: approval-mozilla-beta+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
Alternately we could just disable or hide robocop on beta since we are never shipping native Fennec 13 on any channel.
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #618110 - Flags: review?(mark.finkle)
Comment on attachment 618110 [details] [diff] [review]
patch

might as well fix it for the next train
Attachment #618110 - Flags: review?(mark.finkle) → review+
Comment on attachment 618110 [details] [diff] [review]
patch

[Approval Request Comment]
One-line test-only change to allow this test to pass on beta-branded builds.
Attachment #618110 - Flags: approval-mozilla-beta?
Attachment #618110 - Flags: approval-mozilla-aurora?
Comment on attachment 618110 [details] [diff] [review]
patch

tests only and limited to android.
Attachment #618110 - Flags: approval-mozilla-beta?
Attachment #618110 - Flags: approval-mozilla-beta+
Attachment #618110 - Flags: approval-mozilla-aurora?
Attachment #618110 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/f124e0fb5604
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
No longer blocks: 438871
Whiteboard: [orange] → [perma-orange]
Flags: in-testsuite+
This did not fix the problem.  Downloading and running the tinderbox build from the beta channel, it looks like there are actually no default bookmarks created in a new profile.

Nominating as a beta blocker, because this breaks the first-run experience in builds on the beta channel.
Status: RESOLVED → REOPENED
blocking-fennec1.0: --- → ?
Resolution: FIXED → ---
Target Milestone: Firefox 15 → ---
The bookmarks aren't created in beta 13 because bug 728224 never landed on aurora for version 13.  I'm a little curious why this test was green on Aurora but orange after moving to beta, but in any case it doesn't affect our planned release.  I've hidden robocop on beta for now, since we are never shipping native fennec from the 13.0 branch.
Status: REOPENED → RESOLVED
blocking-fennec1.0: ? → -
Closed: 8 years ago → 8 years ago
status-firefox13: fixed → affected
status-firefox14: affected → fixed
Resolution: --- → WORKSFORME
Target Milestone: --- → Firefox 14
Alas, once I finally remembered to unhide robocop for 14-on-beta, seems to be more about beta than about 13-on-beta.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Attached patch patch 2 — — Splinter Review 
Oops, the original patch here never landed on Aurora for Firefox 14.  Now it needs to land on Beta 14.  In addition, this patch fixes some additional errors that we'll hit on beta after the first patch lands.

[Approval Request Comment]
User impact if declined: Robocop tests are never green on beta.
Risk to taking this patch (and alternatives if risky): Mobile-only test-only fix, to a test that is currently perma-orange.
String or UUID changes made by this patch: None.
Attachment #631077 - Flags: review?(mark.finkle)
Attachment #631077 - Flags: approval-mozilla-beta?
Attachment #631077 - Flags: approval-mozilla-aurora?
Comment on attachment 631077 [details] [diff] [review]
patch 2

mobile-only, test-only
Attachment #631077 - Flags: review?(mark.finkle)
Attachment #631077 - Flags: review+
Attachment #631077 - Flags: approval-mozilla-beta?
Attachment #631077 - Flags: approval-mozilla-beta+
Attachment #631077 - Flags: approval-mozilla-aurora?
Attachment #631077 - Flags: approval-mozilla-aurora+
Blocks: 762632
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fee41489074
Status: REOPENED → ASSIGNED
status-firefox13: affected → wontfix
status-firefox14: fixed → affected
status-firefox15: --- → affected
Target Milestone: Firefox 14 → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/6fee41489074

(Merged by Ed Morley)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.